From: Johannes Sixt <j6t@kdbg.org>
To: Jeff King <peff@peff.net>
Cc: Boxuan Li <liboxuan@connect.hku.hk>,
git@vger.kernel.org, gitster@pobox.com
Subject: Re: [RFC PATCH] userdiff: ship built-in driver config file
Date: Thu, 20 Jun 2019 09:41:13 +0200 [thread overview]
Message-ID: <1db4a03e-5bc2-673d-6d89-bf654b785129@kdbg.org> (raw)
In-Reply-To: <20190619183931.GA28145@sigill.intra.peff.net>
Am 19.06.19 um 20:39 schrieb Jeff King:
> But without that, I have to wonder what problem we are really solving.
You have a point here.
> Now it's baked into the binary. Later it will be baked into the
> distribution, but we still don't want anybody to touch it because their
> changes will be overwritten.
Having the patterns outside the binary reduces our mental barrier to
accept additional patterns or slightly modified patterns for new file
types, like we had recently for octave that are just a small extension
to the matlab patterns.
But we are not solving a technical problem or a problem our users have,
AFAICS.
> I guess it's a little easier for somebody
> to find .../share/git-core/userdiff and use it as a template than it is
> to find the definitions in the source. But it's not exactly easy.
Having a slightly easiser to discover database may count as an advantage. ;)
-- Hannes
next prev parent reply other threads:[~2019-06-20 7:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 16:54 [RFC PATCH] userdiff: ship built-in driver config file Boxuan Li
2019-06-18 20:32 ` Johannes Sixt
2019-06-18 20:50 ` Johannes Sixt
2019-06-19 3:49 ` Jeff King
2019-06-19 6:30 ` Johannes Sixt
2019-06-19 15:02 ` Junio C Hamano
2019-06-19 18:39 ` Jeff King
2019-06-20 7:41 ` Johannes Sixt [this message]
2019-06-19 14:50 ` Junio C Hamano
2019-06-19 3:58 ` Jeff King
2019-06-19 15:32 ` LI, BO XUAN
2019-06-19 18:42 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1db4a03e-5bc2-673d-6d89-bf654b785129@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=liboxuan@connect.hku.hk \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).