From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: "Steven Jeuris via GitGitGadget" <gitgitgadget@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Jeff King" <peff@peff.net>,
"Steven Jeuris" <steven.jeuris@gmail.com>,
"Steven Jeuris" <steven.jeuris@3shape.com>
Subject: Re: [PATCH v2] userdiff: better method/property matching for C#
Date: Tue, 26 Mar 2024 14:38:41 -0700 [thread overview]
Message-ID: <xmqqfrwc8yhq.fsf@gitster.g> (raw)
In-Reply-To: <pull.1682.v2.git.git.1709756493673.gitgitgadget@gmail.com> (Steven Jeuris via GitGitGadget's message of "Wed, 06 Mar 2024 20:21:33 +0000")
"Steven Jeuris via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Steven Jeuris <steven.jeuris@3shape.com>
>
> - Support multi-line methods by not requiring closing parenthesis.
> - Support multiple generics (comma was missing before).
> - Add missing `foreach`, `lock` and `fixed` keywords to skip over.
> - Remove `instanceof` keyword, which isn't C#.
> - Also detect non-method keywords not positioned at the start of a line.
> - Added tests; none existed before.
>
> The overall strategy is to focus more on what isn't expected for
> method/property definitions, instead of what is, but is fully optional.
>
> Signed-off-by: Steven Jeuris <steven.jeuris@gmail.com>
> ---
> userdiff: better method/property matching for C#
>
> Change since v1: I removed "from" from the list of keywords to skip.
> First, I considered adding "await", but I discovered both "await" and
> "from" are "contextual keywords", which unlike the other keywords
> currently listed, aren't reserved, and can thus cause false negatives.
> I.e., it is valid to have a method named "await" or "from". In edge
> cases, this may lead to false positives, but a different exclusion rule
> will need to be added to handle these.
It seems that this has seen no reviews. I somehow find it doubtful
that Ævar or Peff would be writing too much C# to be familiar with
the language to judge the quality of the patch, but can somebody
with C# background (I hear that its most common use is for
developing Windows applications etc. there) chip in?
Thanks.
next prev parent reply other threads:[~2024-03-26 21:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-25 17:33 [PATCH] userdiff: better method/property matching for C# Steven Jeuris via GitGitGadget
2024-03-06 20:21 ` [PATCH v2] " Steven Jeuris via GitGitGadget
2024-03-07 2:11 ` Junio C Hamano
2024-03-16 18:14 ` Linus Arver
2024-03-26 21:38 ` Junio C Hamano [this message]
2024-03-27 8:40 ` Jeff King
2024-03-27 7:30 ` Johannes Sixt
2024-03-28 8:07 ` [PATCH v3] " Steven Jeuris via GitGitGadget
2024-03-28 19:14 ` [PATCH v4] " Steven Jeuris via GitGitGadget
2024-03-28 19:33 ` Junio C Hamano
2024-03-30 18:49 ` Johannes Sixt
2024-04-03 21:42 ` [PATCH v5] " Steven Jeuris via GitGitGadget
2024-04-05 22:02 ` Johannes Sixt
2024-04-05 22:10 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfrwc8yhq.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=peff@peff.net \
--cc=steven.jeuris@3shape.com \
--cc=steven.jeuris@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).