Re: [PATCH v2] userdiff: better method/property matching for C#

[Jeff King <peff@peff.net>]

On Tue, Mar 26, 2024 at 02:38:41PM -0700, Junio C Hamano wrote:

> >     userdiff: better method/property matching for C#
> >     
> >     Change since v1: I removed "from" from the list of keywords to skip.
> >     First, I considered adding "await", but I discovered both "await" and
> >     "from" are "contextual keywords", which unlike the other keywords
> >     currently listed, aren't reserved, and can thus cause false negatives.
> >     I.e., it is valid to have a method named "await" or "from". In edge
> >     cases, this may lead to false positives, but a different exclusion rule
> >     will need to be added to handle these.
> 
> It seems that this has seen no reviews.  I somehow find it doubtful
> that Ævar or Peff would be writing too much C# to be familiar with
> the language to judge the quality of the patch, but can somebody
> with C# background (I hear that its most common use is for
> developing Windows applications etc. there) chip in?

Yeah, sorry, I have never written a line of C# in my life, so I have
been dutifully ignoring this series. :)

-Peff