From: Junio C Hamano <gitster@pobox.com>
To: larsxschneider@gmail.com
Cc: git@vger.kernel.org, luke@diamand.org
Subject: Re: [PATCH v2 3/4] git-p4: Fix t9815 git-p4-submit-fail test case on OS X
Date: Sun, 04 Oct 2015 11:23:09 -0700 [thread overview]
Message-ID: <xmqqegha1oj6.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1443981977-64604-4-git-send-email-larsxschneider@gmail.com> (larsxschneider@gmail.com's message of "Sun, 4 Oct 2015 11:06:16 -0700")
larsxschneider@gmail.com writes:
> + if test_have_prereq CYGWIN; then
> + : # NOOP
> + elif test_have_prereq DARWIN; then
> + stat -f %Sp text | egrep ^-r-- &&
> + stat -f %Sp text+x | egrep ^-r-x
> + else
> stat --format=%A text | egrep ^-r-- &&
> stat --format=%A text+x | egrep ^-r-x
> fi
Not a new problem but why do we need "stat" here?
Shouldn't "test -r", "! test -x", and their usual friends be
sufficient for the purpose of the test and are more portable?
next prev parent reply other threads:[~2015-10-04 18:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-04 18:06 [PATCH v2 0/4] Add Travis CI support larsxschneider
2015-10-04 18:06 ` [PATCH v2 1/4] " larsxschneider
2015-10-05 9:43 ` Johannes Schindelin
2015-10-04 18:06 ` [PATCH v2 2/4] Add prereq to detect OS X larsxschneider
2015-10-04 18:28 ` Junio C Hamano
2015-10-04 18:46 ` Lars Schneider
2015-10-04 18:06 ` [PATCH v2 3/4] git-p4: Fix t9815 git-p4-submit-fail test case on " larsxschneider
2015-10-04 18:23 ` Junio C Hamano [this message]
2015-10-04 18:44 ` Lars Schneider
2015-10-04 20:18 ` Pete Wyckoff
2015-10-05 3:08 ` Torsten Bögershausen
2015-10-04 18:06 ` [PATCH v2 4/4] git-p4: Disable t9819 git-p4-case-folding test " larsxschneider
2015-10-04 18:26 ` Junio C Hamano
2015-10-04 18:38 ` Lars Schneider
2015-10-04 18:49 ` Junio C Hamano
2015-10-05 9:55 ` [PATCH v2 0/4] Add Travis CI support Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqegha1oj6.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
--cc=luke@diamand.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).