From: Lars Schneider <larsxschneider@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, luke@diamand.org
Subject: Re: [PATCH v2 4/4] git-p4: Disable t9819 git-p4-case-folding test on OS X
Date: Sun, 4 Oct 2015 11:38:31 -0700 [thread overview]
Message-ID: <E363C89B-7039-49F6-B723-8609DBAF2C64@gmail.com> (raw)
In-Reply-To: <xmqqa8ry1ods.fsf@gitster.mtv.corp.google.com>
On 04 Oct 2015, at 11:26, Junio C Hamano <gitster@pobox.com> wrote:
> larsxschneider@gmail.com writes:
>
>> From: Lars Schneider <larsxschneider@gmail.com>
>>
>> The OS X file system is case insensitive by default. Consequently this
>> test does not apply.
>>
>> Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
>> ---
>> t/t9819-git-p4-case-folding.sh | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/t/t9819-git-p4-case-folding.sh b/t/t9819-git-p4-case-folding.sh
>> index 78f1d0f..c69ae47 100755
>> --- a/t/t9819-git-p4-case-folding.sh
>> +++ b/t/t9819-git-p4-case-folding.sh
>> @@ -4,6 +4,11 @@ test_description='interaction with P4 case-folding'
>>
>> . ./lib-git-p4.sh
>>
>> +if test_have_prereq DARWIN; then
>> + skip_all='skipping P4 case-folding tests; OS X file system is case insensitive by default'
>> + test_done
>> +fi
>
> Makes one wonder what should happen on Windows, or vfat mounted on
> Linux for that matter. IOW, shouldn't the prerequisite be more like
> "do not run any of these tests if the filesystem does not allow us
> to have two files in different cases at the same time"?
>
> Perhaps
>
> if ! test_have_prereq CASE_INSENSITIVE_FS
> then
> skip_all=...
> test_done
> fi
>
> instead, or something?
Agreed! Although I think the “!” in the if clause is not correct.
By the way... what formatting should I use?
if foo
then
bar
or
if foo; then
bar
I think the latter is more used in the code base.
- Lars
next prev parent reply other threads:[~2015-10-04 18:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-04 18:06 [PATCH v2 0/4] Add Travis CI support larsxschneider
2015-10-04 18:06 ` [PATCH v2 1/4] " larsxschneider
2015-10-05 9:43 ` Johannes Schindelin
2015-10-04 18:06 ` [PATCH v2 2/4] Add prereq to detect OS X larsxschneider
2015-10-04 18:28 ` Junio C Hamano
2015-10-04 18:46 ` Lars Schneider
2015-10-04 18:06 ` [PATCH v2 3/4] git-p4: Fix t9815 git-p4-submit-fail test case on " larsxschneider
2015-10-04 18:23 ` Junio C Hamano
2015-10-04 18:44 ` Lars Schneider
2015-10-04 20:18 ` Pete Wyckoff
2015-10-05 3:08 ` Torsten Bögershausen
2015-10-04 18:06 ` [PATCH v2 4/4] git-p4: Disable t9819 git-p4-case-folding test " larsxschneider
2015-10-04 18:26 ` Junio C Hamano
2015-10-04 18:38 ` Lars Schneider [this message]
2015-10-04 18:49 ` Junio C Hamano
2015-10-05 9:55 ` [PATCH v2 0/4] Add Travis CI support Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E363C89B-7039-49F6-B723-8609DBAF2C64@gmail.com \
--to=larsxschneider@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=luke@diamand.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).