git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH/RFC] setup: update error message to be more meaningful
Date: Fri, 28 Jul 2017 20:53:05 -0700	[thread overview]
Message-ID: <xmqqefszlx0e.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1501296270.2112.2.camel@gmail.com> (Kaartic Sivaraam's message of "Sat, 29 Jul 2017 08:14:30 +0530")

Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> writes:

> Though the message seems to be most fitting one, I'm a little reluctant
> to use it as it "might" create a wrong picture on the minds of the user
> making them think this would be the case in other cases too, which we
> know is not true. For example,
>
>
>     git log -p --full-diff master --stat
>
>     git commit -v Makefile --amend

These are accepted not by design but by accident.  

I do not think we even document that you are allowed to do these in
"log" and "commit" manual pages, and we should discourage them (I do
not even mind eventually removing these with the usual deprecation
dance, but I do not think it is worth the noise).


  reply	other threads:[~2017-07-29  3:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-25 17:57 [PATCH/RFC] setup: update error message to be more meaningful Kaartic Sivaraam
2017-07-25 18:16 ` Kaartic Sivaraam
2017-07-25 21:21 ` Jonathan Nieder
2017-07-26 13:08   ` Kaartic Sivaraam
2017-07-26 20:09   ` Junio C Hamano
2017-07-29  2:44     ` Kaartic Sivaraam
2017-07-29  3:53       ` Junio C Hamano [this message]
2017-07-29 12:13         ` Kaartic Sivaraam
2017-07-29 12:41           ` [PATCH] " Kaartic Sivaraam
2017-07-29 16:10           ` [PATCH/RFC] " Junio C Hamano
2017-07-30 10:47             ` Kaartic Sivaraam
2017-07-30 11:03               ` Kaartic Sivaraam
2017-10-02 17:30     ` [PATCH v2] " Kaartic Sivaraam
2017-10-03  0:32       ` Junio C Hamano
2017-10-04 14:18         ` Kaartic Sivaraam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqefszlx0e.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=kaarticsivaraam91196@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).