From: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
To: git@vger.kernel.org
Subject: [PATCH/RFC] setup: update error message to be more meaningful
Date: Tue, 25 Jul 2017 17:57:09 +0000 [thread overview]
Message-ID: <0102015d7ae53b0a-a6505296-9257-4b0d-84d6-2152e17eb070-000000@eu-west-1.amazonses.com> (raw)
The error message shown when a flag is found when expecting a
filename wasn't clear as it didn't communicate what was wrong
using the 'suitable' words in *all* cases.
Correct case,
$ git rev-parse commit.c --flags
commit.c
--flags
fatal: bad flag '--flags' used after filename
Incorrect case,
$ git grep "test" -n
fatal: bad flag '-n' used after filename
Change the error message to be general and communicative. This results
in the following output,
$ git rev-parse commit.c --flags
commit.c
--flags
fatal: found flag '--flags' in place of a filename
$ git grep "test" -n
fatal: found flag '-n' in place of a filename
Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
---
setup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/setup.c b/setup.c
index 860507e1fdb2d..0433d7889e6b3 100644
--- a/setup.c
+++ b/setup.c
@@ -230,7 +230,7 @@ void verify_filename(const char *prefix,
int diagnose_misspelt_rev)
{
if (*arg == '-')
- die("bad flag '%s' used after filename", arg);
+ die("found flag '%s' in place of a filename", arg);
if (looks_like_pathspec(arg) || check_filename(prefix, arg))
return;
die_verify_filename(prefix, arg, diagnose_misspelt_rev);
--
https://github.com/git/git/pull/388
next reply other threads:[~2017-07-25 17:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 17:57 Kaartic Sivaraam [this message]
2017-07-25 18:16 ` [PATCH/RFC] setup: update error message to be more meaningful Kaartic Sivaraam
2017-07-25 21:21 ` Jonathan Nieder
2017-07-26 13:08 ` Kaartic Sivaraam
2017-07-26 20:09 ` Junio C Hamano
2017-07-29 2:44 ` Kaartic Sivaraam
2017-07-29 3:53 ` Junio C Hamano
2017-07-29 12:13 ` Kaartic Sivaraam
2017-07-29 12:41 ` [PATCH] " Kaartic Sivaraam
2017-07-29 16:10 ` [PATCH/RFC] " Junio C Hamano
2017-07-30 10:47 ` Kaartic Sivaraam
2017-07-30 11:03 ` Kaartic Sivaraam
2017-10-02 17:30 ` [PATCH v2] " Kaartic Sivaraam
2017-10-03 0:32 ` Junio C Hamano
2017-10-04 14:18 ` Kaartic Sivaraam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0102015d7ae53b0a-a6505296-9257-4b0d-84d6-2152e17eb070-000000@eu-west-1.amazonses.com \
--to=kaarticsivaraam91196@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).