From: Junio C Hamano <gitster@pobox.com>
To: Han-Wen Nienhuys <hanwen@google.com>
Cc: git@vger.kernel.org, peff@peff.net, bmwill@google.com
Subject: Re: [PATCH 4/4] Move documentation of string_list into string-list.h
Date: Tue, 26 Sep 2017 14:22:25 +0900 [thread overview]
Message-ID: <xmqqefquavam.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <xmqqing6aw0w.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Tue, 26 Sep 2017 14:06:39 +0900")
Junio C Hamano <gitster@pobox.com> writes:
>
> Thanks. I am not sure if you can safely reorder the contents of the
> header files in general, but I trust that you made sure that this
> does not introduce problems (e.g. referrals before definition).
Alas, this time it seems my trust was grossly misplaced. Discarding
this patch and redoing the integration cycle for the day.
next prev parent reply other threads:[~2017-09-26 5:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 15:59 [PATCH 0/4] Assorted comment fixes Han-Wen Nienhuys
2017-09-25 15:59 ` [PATCH 1/4] Fix typo in submodule.h Han-Wen Nienhuys
2017-09-25 15:59 ` [PATCH 2/4] Clarify return value ownership of real_path and read_gitfile_gently Han-Wen Nienhuys
2017-09-25 17:24 ` Brandon Williams
2017-09-26 5:01 ` Junio C Hamano
2017-09-25 15:59 ` [PATCH 3/4] Document submodule_to_gitdir Han-Wen Nienhuys
2017-09-25 17:25 ` Brandon Williams
2017-09-25 15:59 ` [PATCH 4/4] Move documentation of string_list into string-list.h Han-Wen Nienhuys
2017-09-25 17:40 ` Brandon Williams
2017-09-25 20:05 ` Stefan Beller
2017-09-27 15:59 ` Andrey Rybak
2017-09-26 5:06 ` Junio C Hamano
2017-09-26 5:22 ` Junio C Hamano [this message]
2017-09-26 11:22 ` Han-Wen Nienhuys
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqefquavam.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=hanwen@google.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).