git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Han-Wen Nienhuys <hanwen@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
	Brandon Williams <bmwill@google.com>
Subject: Re: [PATCH 4/4] Move documentation of string_list into string-list.h
Date: Tue, 26 Sep 2017 13:22:26 +0200	[thread overview]
Message-ID: <CAFQ2z_PhSus5yBvG0FV+8DRHbR+OAzFB74sodfEN7YvPjhb3XQ@mail.gmail.com> (raw)
In-Reply-To: <xmqqefquavam.fsf@gitster.mtv.corp.google.com>

On Tue, Sep 26, 2017 at 7:22 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
>>
>> Thanks.  I am not sure if you can safely reorder the contents of the
>> header files in general, but I trust that you made sure that this
>> does not introduce problems (e.g. referrals before definition).
>
> Alas, this time it seems my trust was grossly misplaced.  Discarding
> this patch and redoing the integration cycle for the day.

Oops, my bad.

I resent the remaining patches. They do compile now :)

--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado

      reply	other threads:[~2017-09-26 11:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-25 15:59 [PATCH 0/4] Assorted comment fixes Han-Wen Nienhuys
2017-09-25 15:59 ` [PATCH 1/4] Fix typo in submodule.h Han-Wen Nienhuys
2017-09-25 15:59 ` [PATCH 2/4] Clarify return value ownership of real_path and read_gitfile_gently Han-Wen Nienhuys
2017-09-25 17:24   ` Brandon Williams
2017-09-26  5:01   ` Junio C Hamano
2017-09-25 15:59 ` [PATCH 3/4] Document submodule_to_gitdir Han-Wen Nienhuys
2017-09-25 17:25   ` Brandon Williams
2017-09-25 15:59 ` [PATCH 4/4] Move documentation of string_list into string-list.h Han-Wen Nienhuys
2017-09-25 17:40   ` Brandon Williams
2017-09-25 20:05     ` Stefan Beller
2017-09-27 15:59     ` Andrey Rybak
2017-09-26  5:06   ` Junio C Hamano
2017-09-26  5:22     ` Junio C Hamano
2017-09-26 11:22       ` Han-Wen Nienhuys [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFQ2z_PhSus5yBvG0FV+8DRHbR+OAzFB74sodfEN7YvPjhb3XQ@mail.gmail.com \
    --to=hanwen@google.com \
    --cc=bmwill@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).