git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
* git tag -l --format results into a malloc fatal error, if tag is signed.
@ 2022-11-22  8:01 Jan-Otto Kröpke
  2022-11-22 17:48 ` René Scharfe
  0 siblings, 1 reply; 3+ messages in thread
From: Jan-Otto Kröpke @ 2022-11-22  8:01 UTC (permalink / raw)
  To: git

Thank you for filling out a Git bug report!
Please answer the following questions to help us understand your issue.

What did you do before the bug happened? (Steps to reproduce your issue)
Create a signed git tag signed by a SSH key and run this command
(orginally executed by goreleaser).
% git -c log.showSignature=false tag -l --format='%(contents:body)' v4.2.2

What did you expect to happen? (Expected behavior)
Command executed successfully

What happened instead? (Actual behavior)
% git -c log.showSignature=false tag -l --format='%(contents:body)' v4.2.2
fatal: Out of memory, malloc failed (tried to allocate
18446744073709551323 bytes)


What's different between what you expected and what actually happened?
See above

Anything else you want to add:

Reference repository: https://github.com/jkroepke/helm-secrets

Please review the rest of the bug report below.
You can delete any lines you don't wish to share.


[System Info]
git version:
git version 2.38.1
cpu: x86_64
no commit associated with this build
sizeof-long: 8
sizeof-size_t: 8
shell-path: /bin/sh
feature: fsmonitor--daemon
uname: Darwin 22.1.0 Darwin Kernel Version 22.1.0: Sun Oct  9 20:14:54
PDT 2022; root:xnu-8792.41.9~2/RELEASE_X86_64 x86_64
compiler info: clang: 14.0.0 (clang-1400.0.29.102)
libc info: no libc information available
$SHELL (typically, interactive shell): /bin/zsh


[Enabled Hooks]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: git tag -l --format results into a malloc fatal error, if tag is signed.
  2022-11-22  8:01 git tag -l --format results into a malloc fatal error, if tag is signed Jan-Otto Kröpke
@ 2022-11-22 17:48 ` René Scharfe
  2022-11-23  0:20   ` Junio C Hamano
  0 siblings, 1 reply; 3+ messages in thread
From: René Scharfe @ 2022-11-22 17:48 UTC (permalink / raw)
  To: Jan-Otto Kröpke, git

Am 22.11.22 um 09:01 schrieb Jan-Otto Kröpke:
> Thank you for filling out a Git bug report!
> Please answer the following questions to help us understand your issue.
>
> What did you do before the bug happened? (Steps to reproduce your issue)
> Create a signed git tag signed by a SSH key and run this command
> (orginally executed by goreleaser).
> % git -c log.showSignature=false tag -l --format='%(contents:body)' v4.2.2
>
> What did you expect to happen? (Expected behavior)
> Command executed successfully
>
> What happened instead? (Actual behavior)
> % git -c log.showSignature=false tag -l --format='%(contents:body)' v4.2.2
> fatal: Out of memory, malloc failed (tried to allocate
> 18446744073709551323 bytes)

Fixed by b01e1c7ef0 (ref-filter: fix parsing of signatures without blank
lines, 2022-11-02).  It hasn't made it into a release, yet, but I would
expect it to be included in an upcoming version 2.38.2.  Discussion:
https://lore.kernel.org/git/Y2IfT0UFJ7H%2FmHMz@coredump.intra.peff.net/.

>
>
> What's different between what you expected and what actually happened?
> See above
>
> Anything else you want to add:
>
> Reference repository: https://github.com/jkroepke/helm-secrets
>
> Please review the rest of the bug report below.
> You can delete any lines you don't wish to share.
>
>
> [System Info]
> git version:
> git version 2.38.1
> cpu: x86_64
> no commit associated with this build
> sizeof-long: 8
> sizeof-size_t: 8
> shell-path: /bin/sh
> feature: fsmonitor--daemon
> uname: Darwin 22.1.0 Darwin Kernel Version 22.1.0: Sun Oct  9 20:14:54
> PDT 2022; root:xnu-8792.41.9~2/RELEASE_X86_64 x86_64
> compiler info: clang: 14.0.0 (clang-1400.0.29.102)
> libc info: no libc information available
> $SHELL (typically, interactive shell): /bin/zsh
>
>
> [Enabled Hooks]


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: git tag -l --format results into a malloc fatal error, if tag is signed.
  2022-11-22 17:48 ` René Scharfe
@ 2022-11-23  0:20   ` Junio C Hamano
  0 siblings, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2022-11-23  0:20 UTC (permalink / raw)
  To: René Scharfe; +Cc: Jan-Otto Kröpke, git

René Scharfe <l.s.r@web.de> writes:

> Fixed by b01e1c7ef0 (ref-filter: fix parsing of signatures without blank
> lines, 2022-11-02).  It hasn't made it into a release, yet, but I would
> expect it to be included in an upcoming version 2.38.2.

I am fairly certain it would be in 2.39 but probably not 2.38
maintenance track, as b01e1c7ef0 seems to have been applied without
considering that it is a maint-worthy material.



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-11-23  0:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-22  8:01 git tag -l --format results into a malloc fatal error, if tag is signed Jan-Otto Kröpke
2022-11-22 17:48 ` René Scharfe
2022-11-23  0:20   ` Junio C Hamano

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).