From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: James <rouzier@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] clean: new option --exclude-from
Date: Wed, 02 Dec 2015 09:25:24 -0800 [thread overview]
Message-ID: <xmqqd1uo69vf.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20151202164712.GA16636@sigill.intra.peff.net> (Jeff King's message of "Wed, 2 Dec 2015 11:47:12 -0500")
Jeff King <peff@peff.net> writes:
> .... So maybe "clean" is really the only place where people care
> about such ad-hoc exclusion. Or maybe this an opportunity to add:
>
> git --exclude='*.o' clean
>
> I dunno. I cannot think of a time when I would have used any of those
> options myself.
Me either and I do not think I ever wanted to use -e to "clean".
I do not think we should liberally add options that apply to
anything "git" in the first place [*1*]. Limit them to ones that
are really special and fundamental that changes the way Git
operates, i.e. "Where is our $GIT_DIR?" is a good thing for users to
be able to tell "git" itself. Compared to that, the ignore patterns
is a fringe that is used only by commands that care about the
working tree (e.g. the global option in "git --exclude='*.o'
ls-tree" would be meaningless).
[Footnote]
*1* It would add unnecessary confusion to the end users; they have
to decide if they need to pass an option before or after the
subcommand name. If the motivation behind the "git --option cmd"
is to share code and semantics for common "--option", we should
instead further refactor command line option handling, just like
the code for config handling allows us to share config_default.
next prev parent reply other threads:[~2015-12-02 17:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 14:44 [PATCH] clean: new option --exclude-from James
2015-11-30 2:24 ` Eric Sunshine
[not found] ` <CAGjXF72PgdjBw03ERVYxj+atvsBXK0LeJ6O3zTZgi3-kv9BWsw@mail.gmail.com>
2015-12-01 22:25 ` Eric Sunshine
2015-12-06 14:58 ` [PATCH v2 1/2] modernize t7300 James
2015-12-06 14:58 ` [PATCH v2 2/2] clean: new option --exclude-from James
2015-12-07 20:56 ` Jeff King
2015-12-07 21:44 ` Junio C Hamano
2015-12-07 22:53 ` Eric Sunshine
2015-12-07 21:40 ` [PATCH v2 1/2] modernize t7300 Junio C Hamano
2015-12-07 22:46 ` Eric Sunshine
2015-12-07 22:50 ` Junio C Hamano
2015-12-07 22:43 ` Eric Sunshine
2015-12-02 0:53 ` [PATCH] clean: new option --exclude-from Jeff King
2015-12-02 2:18 ` Junio C Hamano
2015-12-02 2:44 ` Jeff King
2015-12-02 16:40 ` Junio C Hamano
2015-12-02 16:47 ` Jeff King
2015-12-02 17:25 ` Junio C Hamano [this message]
2015-12-02 17:51 ` Jeff King
2015-12-06 3:51 ` Junio C Hamano
2015-12-07 19:39 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd1uo69vf.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=rouzier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).