From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: James <rouzier@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] clean: new option --exclude-from
Date: Tue, 1 Dec 2015 21:44:03 -0500 [thread overview]
Message-ID: <20151202024403.GA29329@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqq37vl7fux.fsf@gitster.mtv.corp.google.com>
On Tue, Dec 01, 2015 at 06:18:30PM -0800, Junio C Hamano wrote:
> > Should this perhaps be an option to the main "git" to append to the set
> > of excludes?
> >
> > You can kind-of do this already with:
> >
> > git -c core.excludesfile=/path/to/whatever clean ...
> >
> > but of course you might be using core.excludesfile already. I wonder if
> > that config option should take multiple values and respect all of them,
> > rather than last-one-wins.
>
> It is likely that existing users are already using $HOME/.gitconfig
> that sets core.excludesfile=$HOME/.gitconfig as the personal
> fallback, that is overriden, not tweaked, by project specific
> settings of the same variable in .git/config, so that would not fly
> very well, I suspect.
Maybe. I would think the more common setup is:
1. Personal exclude files (e.g., your editor's backup files) come from
~/.gitconfig.
2. Per-project personal excludes go directly into .git/info/exclude.
But you're right that it would be a backwards-incompatible change.
-Peff
next prev parent reply other threads:[~2015-12-02 2:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 14:44 [PATCH] clean: new option --exclude-from James
2015-11-30 2:24 ` Eric Sunshine
[not found] ` <CAGjXF72PgdjBw03ERVYxj+atvsBXK0LeJ6O3zTZgi3-kv9BWsw@mail.gmail.com>
2015-12-01 22:25 ` Eric Sunshine
2015-12-06 14:58 ` [PATCH v2 1/2] modernize t7300 James
2015-12-06 14:58 ` [PATCH v2 2/2] clean: new option --exclude-from James
2015-12-07 20:56 ` Jeff King
2015-12-07 21:44 ` Junio C Hamano
2015-12-07 22:53 ` Eric Sunshine
2015-12-07 21:40 ` [PATCH v2 1/2] modernize t7300 Junio C Hamano
2015-12-07 22:46 ` Eric Sunshine
2015-12-07 22:50 ` Junio C Hamano
2015-12-07 22:43 ` Eric Sunshine
2015-12-02 0:53 ` [PATCH] clean: new option --exclude-from Jeff King
2015-12-02 2:18 ` Junio C Hamano
2015-12-02 2:44 ` Jeff King [this message]
2015-12-02 16:40 ` Junio C Hamano
2015-12-02 16:47 ` Jeff King
2015-12-02 17:25 ` Junio C Hamano
2015-12-02 17:51 ` Jeff King
2015-12-06 3:51 ` Junio C Hamano
2015-12-07 19:39 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151202024403.GA29329@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rouzier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).