From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Jonathan Tan <jonathantanmy@google.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] fixup! use perl instead of sed
Date: Wed, 10 May 2017 07:38:45 +0900 [thread overview]
Message-ID: <xmqqd1bh1wqy.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CACBZZX5DF6sTTYSUpYnvas925N-XsoUGrM-bYbAN_67g8-w2GQ@mail.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Tue, 9 May 2017 19:00:14 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> On Tue, May 9, 2017 at 6:45 PM, Jonathan Tan <jonathantanmy@google.com> wrote:
> ...
>> # Tweak the push output to make the push option outside the cert
>> # different, then replay it on a fresh dst, checking that ff is not
>> # deleted.
>> - sed -i "s/\\([^ ]\\)bar/\\1baz/" push &&
>> + perl -pe "s/([^ ])bar/\\1baz/" push >push.tweak &&
>> prepare_dst &&
>> git -C dst config receive.certnonceseed sekrit &&
>> git -C dst config receive.advertisepushoptions 1 &&
>> - git receive-pack dst <push >out &&
>> + git receive-pack dst <push.tweak >out &&
>
> The test should have a PERL prerequisite now, that's missing.
For a single-liner like this, our stance has always been that t/
scripts can assume _some_ version of Perl interpreter available for
use, cf. t/README where it lists prerequisites and explains them:
- PERL
Git wasn't compiled with NO_PERL=YesPlease.
Even without the PERL prerequisite, tests can assume there is a
usable perl interpreter at $PERL_PATH, though it need not be
particularly modern.
So unless "receive-pack" that is being tested here requires Perl at
runtime, we do not want PERL prerequisite for this test.
> Also using \1 will likely be deprecated in future versions of perl at
> some point:
>
> $ echo hifoo | perl -wpe "s/([^ ])bar/\\1baz/"
> \1 better written as $1 at -e line 1.
> hifoo
Very good advice from a Perl expert; thanks.
next prev parent reply other threads:[~2017-05-09 22:38 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 23:46 [PATCH 0/3] Clarify interaction between signed pushes and push options Jonathan Tan
2017-05-05 23:46 ` [PATCH 1/3] docs: correct receive.advertisePushOptions default Jonathan Tan
2017-05-05 23:50 ` Brandon Williams
2017-05-05 23:53 ` Stefan Beller
2017-05-05 23:58 ` Jonathan Nieder
2017-05-05 23:46 ` [PATCH 2/3] receive-pack: verify push options in cert Jonathan Tan
2017-05-06 0:02 ` Stefan Beller
2017-05-06 0:06 ` Brandon Williams
2017-05-06 0:20 ` Jonathan Nieder
2017-05-06 0:10 ` Jonathan Nieder
2017-05-05 23:46 ` [PATCH 3/3] protocol docs: explain receive-pack push options Jonathan Tan
2017-05-06 0:10 ` Stefan Beller
2017-05-06 0:26 ` Jonathan Nieder
2017-05-08 21:27 ` Jonathan Tan
2017-05-08 5:44 ` [PATCH 0/3] Clarify interaction between signed pushes and " Junio C Hamano
2017-05-08 21:33 ` [PATCH v2 0/2] " Jonathan Tan
2017-05-08 21:33 ` [PATCH v2 1/2] docs: correct receive.advertisePushOptions default Jonathan Tan
2017-05-08 21:33 ` [PATCH v2 2/2] receive-pack: verify push options in cert Jonathan Tan
2017-05-09 3:15 ` Junio C Hamano
2017-05-09 3:34 ` Junio C Hamano
2017-05-09 16:45 ` [PATCH] fixup! use perl instead of sed Jonathan Tan
2017-05-09 17:00 ` Ævar Arnfjörð Bjarmason
2017-05-09 19:23 ` [PATCH v3 0/2] Clarify interaction between signed pushes and push options Jonathan Tan
2017-05-09 21:01 ` [PATCH v3] fixup! don't use perl -i because it's not portable Jonathan Tan
2017-05-09 19:23 ` [PATCH v3 1/2] docs: correct receive.advertisePushOptions default Jonathan Tan
2017-05-09 19:23 ` [PATCH v3 2/2] receive-pack: verify push options in cert Jonathan Tan
2017-05-09 20:43 ` [PATCH] fixup! use perl instead of sed Johannes Sixt
2017-05-09 21:04 ` Jonathan Tan
2017-05-09 21:08 ` Ævar Arnfjörð Bjarmason
2017-05-09 22:38 ` Junio C Hamano [this message]
2017-05-09 23:44 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd1bh1wqy.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).