git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Nathan PAYRE <second.payre@gmail.com>
Cc: Nathan Payre <nathan.payre@etu.univ-lyon1.fr>,
	Git Mailing List <git@vger.kernel.org>,
	Matthieu Moy <matthieu.moy@univ-lyon1.fr>,
	Timothee Albertin <timothee.albertin@etu.univ-lyon1.fr>,
	Daniel Bensoussan <daniel.bensoussan--bohm@etu.univ-lyon1.fr>
Subject: Re: [PATCH v2] send-email: extract email-parsing code into a subroutine
Date: Wed, 06 Dec 2017 15:06:35 -0800	[thread overview]
Message-ID: <xmqqd13rfock.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAGb4CBWZciqxdfpSkK1vezhiuSYX5Yy-xSq=Uj4h+vhRo9uyoQ@mail.gmail.com> (Nathan PAYRE's message of "Wed, 6 Dec 2017 23:55:09 +0100")

Nathan PAYRE <second.payre@gmail.com> writes:

> Junio C Hamano <gitster@pobox.com>: writes:
>
>> ... throughout this patch, not limited to this section, indentation
>> is strange and there seem to be many "print" that show messages that
>> do not seem to be meant for end-user consumption.  I can see that
>> this aspires to improve the readability, but not quite yet ;-).
>
> Hmmm I'm wondering who place thoses print in my code !
> I will fix it fast. :-)

Don't make waste by being hasty, though.  The print statements were
bad, but funny indentation was more distracting and will be worse
hindrance from the maintainabaility's point of view.

Thanks.

  parent reply	other threads:[~2017-12-06 23:06 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-02 17:02 [PATCH] send-email: extract email-parsing code into a subroutine Payre Nathan
2017-12-02 17:11 ` Nathan PAYRE
     [not found] ` <445d0838cf2a4107bad95d5cc2d38a05@BPMBX2013-01.univ-lyon1.fr>
2017-12-03 21:20   ` Matthieu Moy
2017-12-03 22:00 ` Ævar Arnfjörð Bjarmason
2017-12-03 23:41   ` Nathan PAYRE
2017-12-04 13:45     ` Junio C Hamano
2017-12-06 15:38       ` [PATCH v2] " Nathan Payre
2017-12-06 21:39         ` Junio C Hamano
2017-12-06 22:55           ` Nathan PAYRE
2017-12-06 23:02             ` [PATCH v3] " Nathan Payre
2017-12-06 23:12               ` Ævar Arnfjörð Bjarmason
2017-12-07 10:28               ` [PATCH v4] " Nathan Payre
     [not found]               ` <ff9066a7209b4e21867d933542f8eece@BPMBX2013-01.univ-lyon1.fr>
2017-12-07 13:22                 ` Matthieu Moy
2017-12-07 14:14                   ` Ævar Arnfjörð Bjarmason
2017-12-06 23:06             ` Junio C Hamano [this message]
2017-12-07  7:32             ` [PATCH v2] " Eric Sunshine
     [not found]             ` <2b59497271cd4fada4ff590a001446cf@BPMBX2013-01.univ-lyon1.fr>
2017-12-07  7:57               ` [PATCH v3] " Matthieu Moy
2017-12-09 15:37             ` [PATCH] " Nathan Payre
     [not found]             ` <34c53164f4054ee88354f19fc38ae0c4@BPMBX2013-01.univ-lyon1.fr>
2017-12-11 21:12               ` Matthieu Moy
2017-12-14 10:06                 ` Nathan PAYRE
2017-12-14 11:12                   ` Nathan Payre
     [not found]                   ` <ce70816f94c24754bea9bc8175de4bc4@BPMBX2013-01.univ-lyon1.fr>
2017-12-14 14:05                     ` Matthieu Moy
2017-12-15 15:33                       ` Nathan Payre
     [not found]                       ` <3cafddfe825a4fb4a554f02aa3c025a3@BPMBX2013-01.univ-lyon1.fr>
2017-12-15 15:44                         ` Matthieu Moy
2017-12-06 15:32     ` [PATCH v2] " Nathan Payre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqd13rfock.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=daniel.bensoussan--bohm@etu.univ-lyon1.fr \
    --cc=git@vger.kernel.org \
    --cc=matthieu.moy@univ-lyon1.fr \
    --cc=nathan.payre@etu.univ-lyon1.fr \
    --cc=second.payre@gmail.com \
    --cc=timothee.albertin@etu.univ-lyon1.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).