From: Matthieu Moy <Matthieu.Moy@univ-lyon1.fr>
To: PAYRE NATHAN p1508475 <nathan.payre@etu.univ-lyon1.fr>
Cc: "git\@vger.kernel.org" <git@vger.kernel.org>,
ALBERTIN TIMOTHEE p1514771 <timothee.albertin@etu.univ-lyon1.fr>,
BENSOUSSAN--BOHM DANIEL p1507430
<daniel.bensoussan--bohm@etu.univ-lyon1.fr>
Subject: Re: [PATCH v3] send-email: extract email-parsing code into a subroutine
Date: Thu, 07 Dec 2017 08:57:46 +0100 [thread overview]
Message-ID: <q7h9609jotqd.fsf@orange.lip.ens-lyon.fr> (raw)
In-Reply-To: <2b59497271cd4fada4ff590a001446cf@BPMBX2013-01.univ-lyon1.fr> (PAYRE NATHAN's message of "Wed, 6 Dec 2017 23:02:25 +0000")
PAYRE NATHAN p1508475 <nathan.payre@etu.univ-lyon1.fr> writes:
> Without the "print" used for testing.
But still smoe broken indentation:
> git-send-email.perl | 90 +++++++++++++++++++++++++++++++++++++----------------
> 1 file changed, 63 insertions(+), 27 deletions(-)
>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index 2208dcc21..a10574a56 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -715,41 +715,63 @@ EOT3
> if (!defined $compose_encoding) {
> $compose_encoding = "UTF-8";
> }
> - while(<$c>) {
> - next if m/^GIT:/;
> - if ($in_body) {
> - $summary_empty = 0 unless (/^\n$/);
> - } elsif (/^\n$/) {
> - $in_body = 1;
> - if ($need_8bit_cte) {
> +
> + my %parsed_email;
> + $parsed_email{'body'} = '';
> + while (my $line = <$c>) {
> + next if $line =~ m/^GIT:/;
> + parse_header_line($line, \%parsed_email);
> + if ($line =~ /^\n$/i) {
> + while (my $body_line = <$c>) {
> + if ($body_line !~ m/^GIT:/) {
> + $parsed_email{'body'} = $parsed_email{'body'} . $body_line;
> + }
> + }
> + }
> + }
This may display properly in your text editor with your setting, but
appears broken at least with tab-width=8. Don't mix tabs and spaces. The
Git coding style is to indent with tabs.
To see what I mean, open the script in Emacs and type M-x
whitespace-mode RET.
--
Matthieu Moy
https://matthieu-moy.fr/
next prev parent reply other threads:[~2017-12-07 7:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-02 17:02 [PATCH] send-email: extract email-parsing code into a subroutine Payre Nathan
2017-12-02 17:11 ` Nathan PAYRE
[not found] ` <445d0838cf2a4107bad95d5cc2d38a05@BPMBX2013-01.univ-lyon1.fr>
2017-12-03 21:20 ` Matthieu Moy
2017-12-03 22:00 ` Ævar Arnfjörð Bjarmason
2017-12-03 23:41 ` Nathan PAYRE
2017-12-04 13:45 ` Junio C Hamano
2017-12-06 15:38 ` [PATCH v2] " Nathan Payre
2017-12-06 21:39 ` Junio C Hamano
2017-12-06 22:55 ` Nathan PAYRE
2017-12-06 23:02 ` [PATCH v3] " Nathan Payre
2017-12-06 23:12 ` Ævar Arnfjörð Bjarmason
2017-12-07 10:28 ` [PATCH v4] " Nathan Payre
[not found] ` <ff9066a7209b4e21867d933542f8eece@BPMBX2013-01.univ-lyon1.fr>
2017-12-07 13:22 ` Matthieu Moy
2017-12-07 14:14 ` Ævar Arnfjörð Bjarmason
2017-12-06 23:06 ` [PATCH v2] " Junio C Hamano
2017-12-07 7:32 ` Eric Sunshine
[not found] ` <2b59497271cd4fada4ff590a001446cf@BPMBX2013-01.univ-lyon1.fr>
2017-12-07 7:57 ` Matthieu Moy [this message]
2017-12-09 15:37 ` [PATCH] " Nathan Payre
[not found] ` <34c53164f4054ee88354f19fc38ae0c4@BPMBX2013-01.univ-lyon1.fr>
2017-12-11 21:12 ` Matthieu Moy
2017-12-14 10:06 ` Nathan PAYRE
2017-12-14 11:12 ` Nathan Payre
[not found] ` <ce70816f94c24754bea9bc8175de4bc4@BPMBX2013-01.univ-lyon1.fr>
2017-12-14 14:05 ` Matthieu Moy
2017-12-15 15:33 ` Nathan Payre
[not found] ` <3cafddfe825a4fb4a554f02aa3c025a3@BPMBX2013-01.univ-lyon1.fr>
2017-12-15 15:44 ` Matthieu Moy
2017-12-06 15:32 ` [PATCH v2] " Nathan Payre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=q7h9609jotqd.fsf@orange.lip.ens-lyon.fr \
--to=matthieu.moy@univ-lyon1.fr \
--cc=daniel.bensoussan--bohm@etu.univ-lyon1.fr \
--cc=git@vger.kernel.org \
--cc=nathan.payre@etu.univ-lyon1.fr \
--cc=timothee.albertin@etu.univ-lyon1.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).