From: Junio C Hamano <gitster@pobox.com>
To: George Brown <321.george@gmail.com>
Cc: git@vger.kernel.org, peff@peff.net
Subject: Re: [PATCH] contrib/git-jump: cat output when not a terminal
Date: Sat, 09 May 2020 14:41:52 -0700 [thread overview]
Message-ID: <xmqqd07cvl9b.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <CAFKec1W0-OOQYypP-3VC=dJnuNDrykdQ2xibc=u4D=Zo6if-+Q@mail.gmail.com> (George Brown's message of "Sat, 9 May 2020 20:15:40 +0100")
George Brown <321.george@gmail.com> writes:
> contrib/git-jump: cat output when not a terminal
>
> The current usage to populate Vim's quickfix list cannot be used from
> within the editor as it invokes another instance.
>
> Check if stdout is to a terminal or not. If not simply cat the output.
The are editors that open their own window, or tell an already open
editor instance to edit the buffer (think: emacsclient) and in order
to be functional, they do not have to be launched from inside a
working terminal window (whose input comes from the keyboard---the
test "-t 1" is an approximate check for that).
Wouldn't this change hurt the users of such an editor?
Would it work to set GIT_EDITOR to "cat" while performing the
"populating quickfix list" (whatever that is) operation?
> Signed-off-by: George Brown <321.george@gmail.com>
> ---
> contrib/git-jump/git-jump | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/contrib/git-jump/git-jump b/contrib/git-jump/git-jump
> index 931b0fe3a9..253341c64e 100755
> --- a/contrib/git-jump/git-jump
> +++ b/contrib/git-jump/git-jump
> @@ -19,8 +19,12 @@ EOF
> }
>
> open_editor() {
> - editor=`git var GIT_EDITOR`
> - eval "$editor -q \$1"
> + if test -t 1; then
> + editor=`git var GIT_EDITOR`
> + eval "$editor -q \$1"
> + else
> + cat "$1"
> + fi
> }
>
> mode_diff() {
next prev parent reply other threads:[~2020-05-09 21:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 19:15 [PATCH] contrib/git-jump: cat output when not a terminal George Brown
2020-05-09 21:41 ` Junio C Hamano [this message]
2020-05-09 22:04 ` George Brown
2020-05-09 23:42 ` Junio C Hamano
2020-05-10 9:03 ` George Brown
2020-05-10 16:47 ` Junio C Hamano
2020-05-10 17:33 ` George Brown
2020-05-10 18:12 ` Junio C Hamano
2020-05-10 18:34 ` George Brown
2020-05-10 19:10 ` Junio C Hamano
2020-05-10 19:25 ` George Brown
2020-05-10 19:38 ` Junio C Hamano
2020-05-10 20:20 ` George Brown
2020-05-11 14:31 ` Junio C Hamano
2020-05-11 14:31 ` Jeff King
2020-05-11 15:36 ` Junio C Hamano
2020-05-11 15:42 ` Jeff King
2020-05-11 16:46 ` Re* " Junio C Hamano
2020-05-12 19:23 ` Jeff King
2020-05-12 21:30 ` Junio C Hamano
2020-05-13 4:52 ` Jeff King
-- strict thread matches above, loose matches on Subject: below --
2020-05-10 20:26 Benjamin
2020-05-11 14:33 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd07cvl9b.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=321.george@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).