From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: George Brown <321.george@gmail.com>, git@vger.kernel.org
Subject: Re: Re* [PATCH] contrib/git-jump: cat output when not a terminal
Date: Tue, 12 May 2020 15:23:23 -0400 [thread overview]
Message-ID: <20200512192323.GC54565@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqy2pyqv11.fsf_-_@gitster.c.googlers.com>
On Mon, May 11, 2020 at 09:46:34AM -0700, Junio C Hamano wrote:
> Lest we all forget...
>
> -- >8 --
> Subject: git-jump: just show the list with the "--no-editor" option
Thanks for tying this up. It seems to work as advertised. A few nits:
> +edit=yes
> +
> +while case "$#,$1" in
Tab between "while" and "case"?
> + 0,*) break ;;
> + *,--no-editor) edit=no ;;
> + *,--*) usage >&2; exit 1 ;;
> + *) break ;;
> + esac
> +do
> + shift
> +done
I found the use of "case" in the loop conditional a little unusual. I'd
have probably written:
while test $# -gt 0
do
case "$1" in
--no-editor) edit=no ;;
--*) usage >&2; exit 1 ;;
*) break ;;
esac
shift
done
> @@ -75,4 +87,9 @@ tmp=`mktemp -t git-jump.XXXXXX` || exit 1
> type "mode_$mode" >/dev/null 2>&1 || { usage >&2; exit 1; }
> "mode_$mode" "$@" >"$tmp"
> test -s "$tmp" || exit 0
> -open_editor "$tmp"
> +
> +case "$edit" in
> +yes) open_editor "$tmp" ;;
> +no) cat "$tmp" ;;
> +esac
> +
"diff --check" complains about the empty line.
It probably doesn't matter much, but we could skip the tempfile entirely
in no-editor mode. I.e.:
if test "$edit" = "no"
then
"mode_$mode" "$@"
fi
# otherwise set up trap, mktemp, etc
-Peff
next prev parent reply other threads:[~2020-05-12 19:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 19:15 [PATCH] contrib/git-jump: cat output when not a terminal George Brown
2020-05-09 21:41 ` Junio C Hamano
2020-05-09 22:04 ` George Brown
2020-05-09 23:42 ` Junio C Hamano
2020-05-10 9:03 ` George Brown
2020-05-10 16:47 ` Junio C Hamano
2020-05-10 17:33 ` George Brown
2020-05-10 18:12 ` Junio C Hamano
2020-05-10 18:34 ` George Brown
2020-05-10 19:10 ` Junio C Hamano
2020-05-10 19:25 ` George Brown
2020-05-10 19:38 ` Junio C Hamano
2020-05-10 20:20 ` George Brown
2020-05-11 14:31 ` Junio C Hamano
2020-05-11 14:31 ` Jeff King
2020-05-11 15:36 ` Junio C Hamano
2020-05-11 15:42 ` Jeff King
2020-05-11 16:46 ` Re* " Junio C Hamano
2020-05-12 19:23 ` Jeff King [this message]
2020-05-12 21:30 ` Junio C Hamano
2020-05-13 4:52 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512192323.GC54565@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=321.george@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).