From: Junio C Hamano <gitster@pobox.com>
To: Han-Wen Nienhuys <hanwen@google.com>
Cc: Han-Wen Nienhuys via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Han-Wen Nienhuys <hanwenn@gmail.com>
Subject: Re: [PATCH] refs: unify parse_worktree_ref() and ref_type()
Date: Wed, 21 Sep 2022 09:45:55 -0700 [thread overview]
Message-ID: <xmqqczbo65h8.fsf@gitster.g> (raw)
In-Reply-To: <CAFQ2z_PQFtq-ph1B0tUFDW7ngVwg9++k2M_5rvozsLVisX2+Qg@mail.gmail.com> (Han-Wen Nienhuys's message of "Tue, 20 Sep 2022 10:53:59 +0200")
Han-Wen Nienhuys <hanwen@google.com> writes:
> On Mon, Sep 19, 2022 at 11:43 PM Junio C Hamano <gitster@pobox.com> wrote:
>> > On Tue, Sep 13, 2022 at 5:43 PM Junio C Hamano <gitster@pobox.com> wrote:
>> >> then a better approach would be to have a small helper
>> >> parse_local_worktree_ref() and make the primary one into something
>> >> like
>> >>...
>> >
>> > Thanks, good idea. I'm sending you a v2.
>>
>> is that "v2" <pull.1325.v2.git.git.1663605291172.gitgitgadget@gmail.com>
>> or is there another version of it?
>
> I think so.
>
>> Hmph,
>
> Did I do something wrong?
Not "wrong" per-se, but I was surprised by the patch that looked
quite different from what I expected from your response to the
"small helper" suggestion.
next prev parent reply other threads:[~2022-09-21 16:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 17:01 [PATCH] refs: unify parse_worktree_ref() and ref_type() Han-Wen Nienhuys via GitGitGadget
2022-09-12 19:17 ` Junio C Hamano
2022-09-12 20:13 ` Junio C Hamano
2022-09-13 15:43 ` Junio C Hamano
2022-09-19 14:28 ` Han-Wen Nienhuys
2022-09-19 21:43 ` Junio C Hamano
2022-09-20 8:53 ` Han-Wen Nienhuys
2022-09-21 16:45 ` Junio C Hamano [this message]
2022-09-19 16:34 ` [PATCH v2] " Han-Wen Nienhuys via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqczbo65h8.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=hanwen@google.com \
--cc=hanwenn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).