From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Lars Schneider <larsxschneider@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH v1] travis-ci: build and test Git on Windows
Date: Thu, 23 Mar 2017 12:12:15 -0700 [thread overview]
Message-ID: <xmqqbmsrdcz4.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170323180134.geoyvq7qbm5vujo6@sigill.intra.peff.net> (Jeff King's message of "Thu, 23 Mar 2017 14:01:34 -0400")
Jeff King <peff@peff.net> writes:
> For instance, if it's in the environment, can I push up a branch that
> does "set | grep GFW_CI_TOKEN", open a PR, and see it? I don't know the
> answer.
I think the documentation said
Variables defined in repository settings are the same for all
builds, and when you restart an old build, it uses the latest
values. These variables are not automatically available to
forks.
so we should be safe as long as we do not build against PRs.
On the other hand, perhaps a contributor may want to build and test
his own PR that may affect Windows platform, and such a contributor
may be helped if the main repository sets things up to build against
PRs.
I personally think it is a separate issue and we shouldn't set it up
to build against PRs. If Windows CI wants to help these
contributors, it can give out the token to them, without relying on
the travis setup for the main repository.
https://docs.travis-ci.com/user/environment-variables#Defining-Variables-in-Repository-Settings
next prev parent reply other threads:[~2017-03-23 19:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 6:56 [PATCH v1] travis-ci: build and test Git on Windows Lars Schneider
2017-03-22 15:49 ` Johannes Schindelin
2017-03-23 18:19 ` Lars Schneider
2017-03-22 19:29 ` Junio C Hamano
2017-03-23 16:22 ` Johannes Schindelin
2017-03-23 18:01 ` Jeff King
2017-03-23 19:12 ` Junio C Hamano [this message]
2017-03-23 19:17 ` Jeff King
2017-03-23 19:26 ` Lars Schneider
2017-03-23 19:30 ` Junio C Hamano
2017-03-23 19:36 ` Lars Schneider
2017-03-23 20:10 ` Junio C Hamano
2017-03-23 19:38 ` Jeff King
2017-03-23 20:00 ` Lars Schneider
2017-03-23 20:20 ` Jeff King
2017-03-23 20:30 ` Junio C Hamano
2017-03-23 20:41 ` Jeff King
2017-03-23 20:39 ` Lars Schneider
2017-03-23 20:42 ` Jeff King
2017-03-24 23:50 ` Johannes Schindelin
2017-03-23 21:04 ` Samuel Lijin
2017-03-23 19:15 ` Junio C Hamano
2017-03-23 18:23 ` Lars Schneider
2017-03-23 20:16 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbmsrdcz4.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).