git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Lars Schneider <larsxschneider@gmail.com>
To: Johannes Schindelin <johannes.schindelin@gmx.de>
Cc: git@vger.kernel.org, gitster@pobox.com, peff@peff.net
Subject: Re: [PATCH v1] travis-ci: build and test Git on Windows
Date: Thu, 23 Mar 2017 19:19:14 +0100	[thread overview]
Message-ID: <281F3580-6FC4-40C2-95A6-D8AD2CCF2E54@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1703221641070.3767@virtualbox>


> On 22 Mar 2017, at 16:49, Johannes Schindelin <johannes.schindelin@gmx.de> wrote:
> 
> Hi Lars,
> 
> On Wed, 22 Mar 2017, Lars Schneider wrote:
...
>> +
>> +gfwci () {
>> +	curl \
>> +		-H "Authentication: Bearer $TOKEN" \
>> +		--silent --retry 5 \
>> +		"https://git-for-windows-ci.azurewebsites.net/api/TestNow?$1" |
>> +	sed "$(printf '1s/^\xef\xbb\xbf//')"  # Remove the Byte Order Mark
>> +}
>> +
>> +# Trigger build job
>> +BUILD_ID=$(gfwci "action=trigger&branch=$BRANCH&commit=$COMMIT&skipTests=false")
>> +
>> +# Check if the $BUILD_ID contains a number
>> +case $BUILD_ID in
>> +	''|*[!0-9]*) echo $BUILD_ID && exit 1
> 
> Error messages are delivered that way, and they do not start with digits,
> true. But maybe there is an exit status to indicate to Travis that we
> cannot decide whether the build failed or succeeded in that case? The most
> common cause for an error here is that the VM I use for testing is down
> (which happens every once in a while to save on resources, and I have to
> manually restart it)...

Curl can return the HTTP code... I'll try to find a way to check for this.

> 
>> +echo "Visual Studio Team Services Build #${BUILD_ID}"
> 
> Nice plug, thanks! ;-)
> 
>> +# Wait until build job finished
>> +STATUS=
>> +RESULT=
>> +while true
>> +do
>> +	LAST_STATUS=$STATUS
>> +	STATUS=$(gfwci "action=status&buildId=$BUILD_ID")
>> +	[ "$STATUS" == "$LAST_STATUS" ] || printf "\nStatus: $STATUS "
>> +	printf "."
>> +
>> +	case $STATUS in
>> +		inProgress|postponed|notStarted) sleep 10                      ;; # continue
>> +		         "completed: succeeded") RESULT="success";        break;; # success
>> +		                              *) echo "Unknown: $STATUS"; break;; # failure
> 
> Well, there are more values for the status, and we know them, but we do
> not handle them. Maybe "Unhandled status:"?

Sure! I'll fix that in v2 :-)

- Lars

  reply	other threads:[~2017-03-23 18:19 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-22  6:56 [PATCH v1] travis-ci: build and test Git on Windows Lars Schneider
2017-03-22 15:49 ` Johannes Schindelin
2017-03-23 18:19   ` Lars Schneider [this message]
2017-03-22 19:29 ` Junio C Hamano
2017-03-23 16:22   ` Johannes Schindelin
2017-03-23 18:01     ` Jeff King
2017-03-23 19:12       ` Junio C Hamano
2017-03-23 19:17         ` Jeff King
2017-03-23 19:26           ` Lars Schneider
2017-03-23 19:30             ` Junio C Hamano
2017-03-23 19:36               ` Lars Schneider
2017-03-23 20:10                 ` Junio C Hamano
2017-03-23 19:38             ` Jeff King
2017-03-23 20:00               ` Lars Schneider
2017-03-23 20:20                 ` Jeff King
2017-03-23 20:30                   ` Junio C Hamano
2017-03-23 20:41                     ` Jeff King
2017-03-23 20:39                   ` Lars Schneider
2017-03-23 20:42                     ` Jeff King
2017-03-24 23:50                   ` Johannes Schindelin
2017-03-23 21:04               ` Samuel Lijin
2017-03-23 19:15       ` Junio C Hamano
2017-03-23 18:23   ` Lars Schneider
2017-03-23 20:16 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=281F3580-6FC4-40C2-95A6-D8AD2CCF2E54@gmail.com \
    --to=larsxschneider@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=johannes.schindelin@gmx.de \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).