From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] fixup! log: add exhaustive tests for pattern style options & config
Date: Mon, 15 May 2017 11:18:17 +0900 [thread overview]
Message-ID: <xmqqbmquyiae.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CACBZZX7MXh_9mG1EROZVEEGapBwjzRWzr3S57f6rWLnQe9L+XA@mail.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Sat, 13 May 2017 15:20:17 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> Thanks for the hotfix. I'll fix this in my v2, but do it differently
> in such a way that I can still run these tests on windows.
>
> I.e. the actual test here just needs these odd characters in the
> commit message. It's just an unintended implementation detail of
> test_commit that a tag is being created.
My knee-jerk reaction matched Dscho's, but grep is about contents,
and we should be able to test this if we used a sensible tagnames or
didn't use any. Glad to see somebody can step back and think ;-)
next prev parent reply other threads:[~2017-05-15 2:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 10:50 [PATCH] fixup! log: add exhaustive tests for pattern style options & config Johannes Schindelin
2017-05-12 22:32 ` Junio C Hamano
2017-05-12 23:44 ` Jonathan Nieder
2017-05-13 13:22 ` Ævar Arnfjörð Bjarmason
2017-05-13 19:03 ` Johannes Schindelin
2017-05-15 19:04 ` Jonathan Nieder
2017-05-13 13:20 ` Ævar Arnfjörð Bjarmason
2017-05-15 2:18 ` Junio C Hamano [this message]
2017-05-15 12:19 ` Johannes Schindelin
2017-05-16 0:46 ` Junio C Hamano
2017-05-16 6:15 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbmquyiae.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).