From: Jonathan Nieder <jrnieder@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH] fixup! log: add exhaustive tests for pattern style options & config
Date: Mon, 15 May 2017 12:04:15 -0700 [thread overview]
Message-ID: <20170515190415.GM27400@aiede.svl.corp.google.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1.1705132037050.146734@virtualbox>
Hi,
Johannes Schindelin wrote:
> On Fri, 12 May 2017, Jonathan Nieder wrote:
>> Would something like
>>
>> test PIPE_IN_FILENAME '
>> >"a|b" &&
>> test -f "a|b"
>> '
>>
>> work?
[...]
> Back to the subject: The MSYS2 emulation layer inherits a neat trick from
> Cygwin, where it *can* create file names containing pipe symbols. They
> will be quietly mapped into a private UTF-8 page, and when Cygwin or MSYS2
> read the file back, the file name maps from this page back to ASCII
> transparently.
>
> That strategy is all good and dandy, as long as you stay within the POSIX
> emulation layer.
>
> Git for Windows avoids the POSIX emulation layer as much as possible, for
> speed, and also for robustness.
>
> Which means that Git does *not* map the file names using said private
> UTF-8 code page. And therefore, your test would succeed (because the shell
> script would stay within the POSIX emulation layer, which creates that
> file using above-mentioned strategy), but Git (being a regular Win32
> program) *still* would fail to create said file.
Wow. Thanks for a clear explaination.
I'll be keeping a copy of this message handy for the next time I'm
confused about filename handling in the testsuite on Windows.
Sincerely,
Jonathan
next prev parent reply other threads:[~2017-05-15 19:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 10:50 [PATCH] fixup! log: add exhaustive tests for pattern style options & config Johannes Schindelin
2017-05-12 22:32 ` Junio C Hamano
2017-05-12 23:44 ` Jonathan Nieder
2017-05-13 13:22 ` Ævar Arnfjörð Bjarmason
2017-05-13 19:03 ` Johannes Schindelin
2017-05-15 19:04 ` Jonathan Nieder [this message]
2017-05-13 13:20 ` Ævar Arnfjörð Bjarmason
2017-05-15 2:18 ` Junio C Hamano
2017-05-15 12:19 ` Johannes Schindelin
2017-05-16 0:46 ` Junio C Hamano
2017-05-16 6:15 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170515190415.GM27400@aiede.svl.corp.google.com \
--to=jrnieder@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).