git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Anthony Sottile <asottile@umich.edu>, git@vger.kernel.org
Subject: Re: [PATCH] run-command.c: ensure signaled hook scripts are waited upon
Date: Sat, 22 Feb 2020 09:12:19 -0800	[thread overview]
Message-ID: <xmqqblpq7dho.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20200221063954.GJ1280313@coredump.intra.peff.net> (Jeff King's message of "Fri, 21 Feb 2020 01:39:54 -0500")

Jeff King <peff@peff.net> writes:

> If we assume that most people would prefer this "wait until the hook has
> died" behavior, I think this shouldn't have any unwanted secondary
> effects. I'm on the fence on whether it's what most people would want or
> not (I guess most people don't care either way, because their scripts
> don't ignore SIGINT).

Yeah, and imagining why they deliberately ignore INT (i.e. "because
I want this hook not be interrupted and run to its completion") does
not help guess if they want git to wait for hook's completion or
just go ahead and die of its own signal death.  We could timeout the
waiting and kill such a child forcibly, and that may avoid these
hook script that ignore INT to hang around, but I do not know if
that is desirable.



      reply	other threads:[~2020-02-22 17:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-21  6:06 [PATCH] run-command.c: ensure signaled hook scripts are waited upon Anthony Sottile
2020-02-21  6:39 ` Jeff King
2020-02-22 17:12   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqblpq7dho.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=asottile@umich.edu \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).