From: Jeff King <peff@peff.net>
To: Anthony Sottile <asottile@umich.edu>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] run-command.c: ensure signaled hook scripts are waited upon
Date: Fri, 21 Feb 2020 01:39:54 -0500 [thread overview]
Message-ID: <20200221063954.GJ1280313@coredump.intra.peff.net> (raw)
In-Reply-To: <20200221060636.4507-1-asottile@umich.edu>
On Thu, Feb 20, 2020 at 10:06:36PM -0800, Anthony Sottile wrote:
> In the event of a `^C` while hook scripts are running, ensure that the
> hook processes are cleaned up and do not become zombies. This also ensures
> that upon `^C` execution is not handed back to the terminal until the
> processes have been waited upon.
If we assume that most people would prefer this "wait until the hook has
died" behavior, I think this shouldn't have any unwanted secondary
effects. I'm on the fence on whether it's what most people would want or
not (I guess most people don't care either way, because their scripts
don't ignore SIGINT).
(Earlier in the thread, we discussed possibly swapping the order of the
cleanup code and dropping the signal handler, which could have more
unexpected effects, but that part isn't in this patch).
-Peff
next prev parent reply other threads:[~2020-02-21 6:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 6:06 [PATCH] run-command.c: ensure signaled hook scripts are waited upon Anthony Sottile
2020-02-21 6:39 ` Jeff King [this message]
2020-02-22 17:12 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200221063954.GJ1280313@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=asottile@umich.edu \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).