list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <>
To: "Johannes Schindelin via GitGitGadget" <>
	"Johannes Schindelin" <>,
	"Matthias Aßhauer" <>
Subject: Re: [PATCH] mingw: use modern strftime implementation if possible
Date: Wed, 08 Apr 2020 12:14:16 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Johannes Schindelin via GitGitGadget's message of "Wed, 08 Apr 2020 17:58:49 +0000")

"Johannes Schindelin via GitGitGadget" <>

> From: =?UTF-8?q?Matthias=20A=C3=9Fhauer?= <>
> Microsoft introduced a new "Universal C Runtime Library" (UCRT) with
> Visual Studio 2015. The UCRT comes with a new strftime() implementation
> that supports more date formats. We link git against the older
> "Microsoft Visual C Runtime Library" (MSVCRT), so to use the UCRT
> strftime() we need to load it from ucrtbase.dll using
> Most supported Windows systems should have recieved the UCRT via Windows
> update, but in some cases only MSVCRT might be available. In that case
> we fall back to using that implementation.
> With this change, it is possible to use e.g. the `%g` and `%V` date
> format specifiers, e.g.
> 	git show -s --format=%cd --date=format:‘%g.%V’ HEAD
> Without this change, the user would see this error message on Windows:
> 	fatal: invalid strftime format: '‘%g.%V’'
> This fixes
> Signed-off-by: Matthias Aßhauer <>
> Signed-off-by: Johannes Schindelin <>
> ---
>     Use a modern strftime() on Windows when available
>     This is another contribution that came in via Git for Windows.

Sure.  It would be very surprising if contribution to compat/mingw.c
came in via Git on Macintosh ;-)

Will apply, together with the other one.  Thanks.

  reply	other threads:[~2020-04-08 19:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-08 17:58 Johannes Schindelin via GitGitGadget
2020-04-08 19:14 ` Junio C Hamano [this message]
2020-04-10 14:39   ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [PATCH] mingw: use modern strftime implementation if possible' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).