From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org, "Matthias Aßhauer" <mha1993@live.de>
Subject: Re: [PATCH] mingw: use modern strftime implementation if possible
Date: Fri, 10 Apr 2020 16:39:25 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2004101638420.46@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqblo1pz7b.fsf@gitster.c.googlers.com>
[-- Attachment #1: Type: text/plain, Size: 1738 bytes --]
Hi Junio,
On Wed, 8 Apr 2020, Junio C Hamano wrote:
> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > From: =?UTF-8?q?Matthias=20A=C3=9Fhauer?= <mha1993@live.de>
> >
> > Microsoft introduced a new "Universal C Runtime Library" (UCRT) with
> > Visual Studio 2015. The UCRT comes with a new strftime() implementation
> > that supports more date formats. We link git against the older
> > "Microsoft Visual C Runtime Library" (MSVCRT), so to use the UCRT
> > strftime() we need to load it from ucrtbase.dll using
> > DECLARE_PROC_ADDR()/INIT_PROC_ADDR().
> >
> > Most supported Windows systems should have recieved the UCRT via Windows
> > update, but in some cases only MSVCRT might be available. In that case
> > we fall back to using that implementation.
> >
> > With this change, it is possible to use e.g. the `%g` and `%V` date
> > format specifiers, e.g.
> >
> > git show -s --format=%cd --date=format:‘%g.%V’ HEAD
> >
> > Without this change, the user would see this error message on Windows:
> >
> > fatal: invalid strftime format: '‘%g.%V’'
> >
> > This fixes https://github.com/git-for-windows/git/issues/2495
> >
> > Signed-off-by: Matthias Aßhauer <mha1993@live.de>
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> > Use a modern strftime() on Windows when available
> >
> > This is another contribution that came in via Git for Windows.
>
> Sure. It would be very surprising if contribution to compat/mingw.c
> came in via Git on Macintosh ;-)
What I mean to say with this is that the patches have seen some real-life
testing.
> Will apply, together with the other one. Thanks.
Thanks,
Dscho
prev parent reply other threads:[~2020-04-10 14:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 17:58 [PATCH] mingw: use modern strftime implementation if possible Johannes Schindelin via GitGitGadget
2020-04-08 19:14 ` Junio C Hamano
2020-04-10 14:39 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2004101638420.46@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=mha1993@live.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).