Re: [PATCH v3 0/2] Correctly handle transient files in shared repositories

[Junio C Hamano <gitster@pobox.com>]

Johannes Schindelin <johannes.schindelin@gmx.de> writes:

> Transient files, e.g. commit messages, are writable only by the owner,
> even in shared repositories, to avoid interference between competing
> users working on the same files.
>
> These files are typically not deleted after use. As a consequence, we
> have to delete such files before writing when they are owned by someone
> else than the current user.
>
> The only change relative to v2 is that the second commit message
> clarifies why apply, fsck and fast-import are left unchanged.

I do not think it clarifies to make "fsck" whose lost and found are
written to GIT_DIR and "apply"'s ".rej" share the same "we dunno"
reasoning, though.

For "apply"'s .rej and "rerere"'s resolution, the reason why we
should not touch these codepaths is because we know we should not
muck with permission bits of working tree files (i.e. checkout
refrains from doing so, and these codepaths should be consistent),
not because it is not clear.  It _is_ clear we should not, and that
is because we don't.

I said "I am not convinced" but that is for future discussion of
possibly changing the behaviour of checkout and other things that
touch the working tree files, which hasn't even started.

Other than that, the resulting tree looks good to me, though.

Thanks.

> Reported-by: Yaroslav Halchenko <yoh@onerussian.com>
>
>
> Johannes Schindelin (2):
>   commit: allow editing the commit message even in shared repos
>   Handle more file writes correctly in shared repos
>
>  builtin/commit.c      |  2 +-
>  builtin/fast-export.c |  2 +-
>  builtin/fetch.c       |  2 +-
>  git-compat-util.h     |  1 +
>  wrapper.c             | 13 +++++++++++++
>  5 files changed, 17 insertions(+), 3 deletions(-)