From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: pclouds@gmail.com, git@vger.kernel.org
Subject: Re: [PATCHv8 5/5] pathspec: allow querying for attributes
Date: Thu, 19 May 2016 12:37:56 -0700 [thread overview]
Message-ID: <xmqqa8jlj0tn.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160519010935.27856-6-sbeller@google.com> (Stefan Beller's message of "Wed, 18 May 2016 18:09:35 -0700")
Stefan Beller <sbeller@google.com> writes:
> +test_expect_success 'setup a tree' '
> + mkdir sub &&
> + for p in fileA fileB fileC fileAB fileAC fileBC fileNoLabel fileUnsetLabel fileSetLabel fileValue fileWrongLabel; do
> + : >$p &&
> + git add $p &&
> + : >sub/$p
> + git add sub/$p
> + done &&
> + git commit -m $p &&
What does this $p refer to?
> + git ls-files >actual &&
> + cat <<EOF >expect &&
> +fileA
> +fileAB
> +fileAC
> +fileB
> +fileBC
> +fileC
> +fileNoLabel
> +fileSetLabel
> +fileUnsetLabel
> +fileValue
> +fileWrongLabel
> +sub/fileA
> +sub/fileAB
> +sub/fileAC
> +sub/fileB
> +sub/fileBC
> +sub/fileC
> +sub/fileNoLabel
> +sub/fileSetLabel
> +sub/fileUnsetLabel
> +sub/fileValue
> +sub/fileWrongLabel
> +EOF
> + test_cmp expect actual
> +'
If I were doing this, I'd prepare the list of paths (i.e. expect)
first and then create these paths using that list, i.e.
test_expect_success 'setup a tree' '
cat <<-\EOF >expect &&
fileA
fileAB
...
sub/fileWrongLabel
EOF
mkdir sub &&
while read path
do
: >$path &&
git add $path || return 1
done <expect &&
git commit -m initial &&
git ls-files >actual &&
test_cmp expect actual
'
next prev parent reply other threads:[~2016-05-19 19:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 1:09 [PATCHv8 0/5] pathspec magic extension to search for attributes Stefan Beller
2016-05-19 1:09 ` [PATCHv8 1/5] string list: improve comment Stefan Beller
2016-05-19 18:08 ` Junio C Hamano
2016-05-19 18:12 ` Stefan Beller
2016-05-19 1:09 ` [PATCHv8 2/5] Documentation: fix a typo Stefan Beller
2016-05-19 1:09 ` [PATCHv8 3/5] pathspec: move long magic parsing out of prefix_pathspec Stefan Beller
2016-05-19 1:09 ` [PATCHv8 4/5] pathspec: move prefix check out of the inner loop Stefan Beller
2016-05-19 1:09 ` [PATCHv8 5/5] pathspec: allow querying for attributes Stefan Beller
2016-05-19 18:53 ` Junio C Hamano
2016-05-19 20:42 ` Stefan Beller
2016-05-19 21:00 ` Junio C Hamano
2016-05-19 19:37 ` Junio C Hamano [this message]
2016-05-19 18:55 ` [PATCHv8 0/5] pathspec magic extension to search " Junio C Hamano
2016-05-19 21:00 ` Stefan Beller
2016-05-19 21:05 ` Junio C Hamano
2016-05-19 21:25 ` Stefan Beller
2016-05-20 17:00 ` Junio C Hamano
2016-05-20 18:12 ` Stefan Beller
2016-05-20 18:19 ` Junio C Hamano
2016-05-22 11:45 ` Duy Nguyen
2016-05-23 18:49 ` Stefan Beller
2016-05-24 2:00 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa8jlj0tn.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).