From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Thomas Adam" <thomas@xteddy.org>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Git List" <git@vger.kernel.org>,
"Matthieu Moy" <Matthieu.Moy@imag.fr>,
"Remi Lespinet" <remi.lespinet@ensimag.grenoble-inp.fr>
Subject: Re: [PATCH] git-send-email: fix get_maintainer.pl regression
Date: Tue, 12 Dec 2017 14:19:19 -0800 [thread overview]
Message-ID: <xmqqa7ynzj14.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <87d13jd4fd.fsf@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Tue, 12 Dec 2017 22:25:42 +0100")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> Ripping out Error.pm for our few internal callers is one thing, trying
> to maintain bugwards compatibility with how it throws exceptions for
> users expecting Error.pm objects is another. I think at that point it's
> easier to just stay with Error.pm.
>
> Probably easier to stay with it either way, don't poke sleeping dragons
> and all that, it's working code, even if we wouldn't write it like that
> today the churn probably isn't worth it.
OK, I'm inclined to defer to your judgment.
THanks.
next prev parent reply other threads:[~2017-12-12 22:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 15:48 [PATCH] git-send-email: fix get_maintainer.pl regression Alex Bennée
2017-11-16 16:46 ` Alex Bennée
2017-11-19 2:54 ` Eric Sunshine
2017-11-20 10:44 ` Alex Bennée
2017-11-20 22:34 ` Eric Sunshine
2017-11-20 18:57 ` Eric Sunshine
2017-11-21 0:07 ` Philip Oakley
2017-11-21 0:30 ` Eric Sunshine
2017-11-21 0:32 ` Junio C Hamano
2017-11-20 22:14 ` Eric Sunshine
2017-11-21 20:46 ` Alex Bennée
2017-11-21 20:52 ` Thomas Adam
2017-11-22 1:34 ` Junio C Hamano
2017-12-11 17:13 ` Alex Bennée
2017-12-11 17:26 ` Thomas Adam
2017-12-11 19:46 ` Ævar Arnfjörð Bjarmason
2017-12-12 10:30 ` Thomas Adam
2017-12-12 11:49 ` Ævar Arnfjörð Bjarmason
2017-12-12 16:40 ` Alex Bennée
2017-12-12 18:14 ` Ævar Arnfjörð Bjarmason
2017-12-12 19:35 ` Junio C Hamano
2017-12-12 21:25 ` Ævar Arnfjörð Bjarmason
2017-12-12 22:19 ` Junio C Hamano [this message]
[not found] ` <b131cc195280498ea3a77a37eff8444e@BPMBX2013-01.univ-lyon1.fr>
2017-11-22 8:22 ` Matthieu Moy
2017-11-22 9:05 ` Alex Bennée
2017-11-22 9:49 ` Thomas Adam
2017-11-22 10:44 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa7ynzj14.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@imag.fr \
--cc=alex.bennee@linaro.org \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=remi.lespinet@ensimag.grenoble-inp.fr \
--cc=sunshine@sunshineco.com \
--cc=thomas@xteddy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).