From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Thomas Adam <thomas@xteddy.org>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Junio C Hamano" <gitster@pobox.com>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Git List" <git@vger.kernel.org>,
"Matthieu Moy" <Matthieu.Moy@imag.fr>,
"Remi Lespinet" <remi.lespinet@ensimag.grenoble-inp.fr>
Subject: Re: [PATCH] git-send-email: fix get_maintainer.pl regression
Date: Mon, 11 Dec 2017 20:46:46 +0100 [thread overview]
Message-ID: <CACBZZX58KpQ7=V8GUFfxuMQq_Ar6cmmoXyPx_umUTbU19+0LCw@mail.gmail.com> (raw)
In-Reply-To: <20171211172615.jfsjthkvs4itjpcn@laptop>
On Mon, Dec 11, 2017 at 6:26 PM, Thomas Adam <thomas@xteddy.org> wrote:
> On Mon, Dec 11, 2017 at 05:13:53PM +0000, Alex Bennée wrote:
>> So have we come to a consensus about the best solution here?
>>
>> I'm perfectly happy to send a reversion patch because to be honest
>> hacking on a bunch of perl to handle special mail cases is not my idea
>> of fun spare time hacking ;-)
>>
>> I guess the full solution is to make Mail::Address a hard dependency?
>
> This is what I was suggesting, and then as a follow-up, addressing the point
> that there's a bunch of require() hacks to also get around needing
> hard-dependencies.
I don't know what the right move is here, but just saying that this
could also be built on top of my "Git::Error" wrapper which I added in
"Makefile: replace perl/Makefile.PL with simple make rules" which is
currently cooking.
I.e. we'd just ship a copy of Email::Valid and Mail::Address in
perl/Git/FromCPAN/, use a wrapper to load them, and then we wouldn't
need to if/else this at the code level, just always use the module,
and it would work even on core perl.
next prev parent reply other threads:[~2017-12-11 19:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 15:48 [PATCH] git-send-email: fix get_maintainer.pl regression Alex Bennée
2017-11-16 16:46 ` Alex Bennée
2017-11-19 2:54 ` Eric Sunshine
2017-11-20 10:44 ` Alex Bennée
2017-11-20 22:34 ` Eric Sunshine
2017-11-20 18:57 ` Eric Sunshine
2017-11-21 0:07 ` Philip Oakley
2017-11-21 0:30 ` Eric Sunshine
2017-11-21 0:32 ` Junio C Hamano
2017-11-20 22:14 ` Eric Sunshine
2017-11-21 20:46 ` Alex Bennée
2017-11-21 20:52 ` Thomas Adam
2017-11-22 1:34 ` Junio C Hamano
2017-12-11 17:13 ` Alex Bennée
2017-12-11 17:26 ` Thomas Adam
2017-12-11 19:46 ` Ævar Arnfjörð Bjarmason [this message]
2017-12-12 10:30 ` Thomas Adam
2017-12-12 11:49 ` Ævar Arnfjörð Bjarmason
2017-12-12 16:40 ` Alex Bennée
2017-12-12 18:14 ` Ævar Arnfjörð Bjarmason
2017-12-12 19:35 ` Junio C Hamano
2017-12-12 21:25 ` Ævar Arnfjörð Bjarmason
2017-12-12 22:19 ` Junio C Hamano
[not found] ` <b131cc195280498ea3a77a37eff8444e@BPMBX2013-01.univ-lyon1.fr>
2017-11-22 8:22 ` Matthieu Moy
2017-11-22 9:05 ` Alex Bennée
2017-11-22 9:49 ` Thomas Adam
2017-11-22 10:44 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACBZZX58KpQ7=V8GUFfxuMQq_Ar6cmmoXyPx_umUTbU19+0LCw@mail.gmail.com' \
--to=avarab@gmail.com \
--cc=Matthieu.Moy@imag.fr \
--cc=alex.bennee@linaro.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=remi.lespinet@ensimag.grenoble-inp.fr \
--cc=sunshine@sunshineco.com \
--cc=thomas@xteddy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).