From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org, "Derrick Stolee" <derrickstolee@github.com>,
"Jeff King" <peff@peff.net>,
"Jonathan Tan" <jonathantanmy@google.com>,
"Victoria Dye" <vdye@github.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH 1/4] builtin/repack.c: pass "out" to `prepare_pack_objects`
Date: Mon, 24 Oct 2022 13:47:11 -0700 [thread overview]
Message-ID: <xmqqa65lrltc.fsf@gitster.g> (raw)
In-Reply-To: <1dd4136f6199ac050cec5eb671c36ae05fbf3bdd.1666636974.git.me@ttaylorr.com> (Taylor Blau's message of "Mon, 24 Oct 2022 14:43:03 -0400")
Taylor Blau <me@ttaylorr.com> writes:
> `builtin/repack.c`'s `prepare_pack_objects()` is used to prepare a set
> of arguments to a `pack-objects` process which will generate a desired
> pack.
>
> A future patch will add an `--expire-to` option which allows `git
> repack` to write a cruft pack containing the pruned objects out to a
> separate repository. Prepare for this by teaching that function to write
> packs to an arbitrary location specified by the caller.
>
> All existing callers of `prepare_pack_objects()` will pass `packtmp` for
> `out`, retaining the existing behavior.
It does make sense to allow the caller to specify the name of the
temporary file to be used, but is "out" a good name for that? The
other two arguments are self explanatory both by their type and the
name, but this is of type "const char *" that does not convey what
the string is about at all, so giging a good name to the parameter
is more important than for others.
The patch text itself is very straight-forward. Thanks.
> static void prepare_pack_objects(struct child_process *cmd,
> - const struct pack_objects_args *args)
> + const struct pack_objects_args *args,
> + const char *out)
> {
> strvec_push(&cmd->args, "pack-objects");
> if (args->window)
> @@ -211,7 +212,7 @@ static void prepare_pack_objects(struct child_process *cmd,
> strvec_push(&cmd->args, "--quiet");
> if (delta_base_offset)
> strvec_push(&cmd->args, "--delta-base-offset");
> - strvec_push(&cmd->args, packtmp);
> + strvec_push(&cmd->args, out);
> cmd->git_cmd = 1;
> cmd->out = -1;
> }
> @@ -275,7 +276,7 @@ static void repack_promisor_objects(const struct pack_objects_args *args,
> FILE *out;
> struct strbuf line = STRBUF_INIT;
>
> - prepare_pack_objects(&cmd, args);
> + prepare_pack_objects(&cmd, args, packtmp);
> cmd.in = -1;
>
> /*
> @@ -673,7 +674,7 @@ static int write_cruft_pack(const struct pack_objects_args *args,
> FILE *in, *out;
> int ret;
>
> - prepare_pack_objects(&cmd, args);
> + prepare_pack_objects(&cmd, args, packtmp);
>
> strvec_push(&cmd.args, "--cruft");
> if (cruft_expiration)
> @@ -861,7 +862,7 @@ int cmd_repack(int argc, const char **argv, const char *prefix)
>
> sigchain_push_common(remove_pack_on_signal);
>
> - prepare_pack_objects(&cmd, &po_args);
> + prepare_pack_objects(&cmd, &po_args, packtmp);
>
> show_progress = !po_args.quiet && isatty(2);
next prev parent reply other threads:[~2022-10-24 22:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 18:42 [PATCH 0/4] repack: implement `--expire-to` option Taylor Blau
2022-10-24 18:43 ` [PATCH 1/4] builtin/repack.c: pass "out" to `prepare_pack_objects` Taylor Blau
2022-10-24 20:47 ` Junio C Hamano [this message]
2022-11-07 19:28 ` Derrick Stolee
2022-10-24 18:43 ` [PATCH 2/4] builtin/repack.c: pass "cruft_expiration" to `write_cruft_pack` Taylor Blau
2022-10-24 20:50 ` Junio C Hamano
2022-10-24 18:43 ` [PATCH 3/4] builtin/repack.c: write cruft packs to arbitrary locations Taylor Blau
2022-10-24 21:30 ` Junio C Hamano
2022-10-28 19:42 ` Taylor Blau
2022-11-07 19:32 ` Derrick Stolee
2022-11-07 19:52 ` Taylor Blau
2022-10-24 18:43 ` [PATCH 4/4] builtin/repack.c: implement `--expire-to` for storing pruned objects Taylor Blau
2022-11-07 19:42 ` Derrick Stolee
2022-11-07 19:52 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa65lrltc.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).