mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Derrick Stolee <>
To: Taylor Blau <>,
Cc: "Jeff King" <>,
	"Jonathan Tan" <>,
	"Junio C Hamano" <>,
	"Victoria Dye" <>,
	"Ævar Arnfjörð Bjarmason" <>
Subject: Re: [PATCH 4/4] builtin/repack.c: implement `--expire-to` for storing pruned objects
Date: Mon, 7 Nov 2022 14:42:52 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 10/24/22 2:43 PM, Taylor Blau wrote:
> When pruning objects with `--cruft`, `git repack` offers some
> flexibility when selecting the set of which objects are pruned via the
> `--cruft-expiration` option.

This patch looks good.

Creating these cruft packs in the expire directory does help
remove the main problem of the race condition. This currently
requires some external system to check that no races happened
and it is safe to delete the pack in the expire directory.
Also, that external tool is needed to move that expired pack
(or preferably, only the necessary objects) back into the

Some future series could find a way to handle those situations,
perhaps within 'git fsck' to pull missing reachable objects
from the expire directory. Definitely not required for this
series, though.


  reply	other threads:[~2022-11-07 19:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-24 18:42 [PATCH 0/4] repack: implement `--expire-to` option Taylor Blau
2022-10-24 18:43 ` [PATCH 1/4] builtin/repack.c: pass "out" to `prepare_pack_objects` Taylor Blau
2022-10-24 20:47   ` Junio C Hamano
2022-11-07 19:28     ` Derrick Stolee
2022-10-24 18:43 ` [PATCH 2/4] builtin/repack.c: pass "cruft_expiration" to `write_cruft_pack` Taylor Blau
2022-10-24 20:50   ` Junio C Hamano
2022-10-24 18:43 ` [PATCH 3/4] builtin/repack.c: write cruft packs to arbitrary locations Taylor Blau
2022-10-24 21:30   ` Junio C Hamano
2022-10-28 19:42     ` Taylor Blau
2022-11-07 19:32   ` Derrick Stolee
2022-11-07 19:52     ` Taylor Blau
2022-10-24 18:43 ` [PATCH 4/4] builtin/repack.c: implement `--expire-to` for storing pruned objects Taylor Blau
2022-11-07 19:42   ` Derrick Stolee [this message]
2022-11-07 19:52     ` Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).