From: Junio C Hamano <gitster@pobox.com>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: Philip Oakley <philipoakley@iee.org>, Git List <git@vger.kernel.org>
Subject: Re: clarification of `rev-list --no-walk ^<rev>`?
Date: Mon, 19 Sep 2016 09:12:11 -0700 [thread overview]
Message-ID: <xmqq8tunhns4.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <3b06b9ee-3975-acf1-41d8-02b774a2dd3c@drmicha.warpmail.net> (Michael J. Gruber's message of "Mon, 19 Sep 2016 15:46:35 +0200")
Michael J Gruber <git@drmicha.warpmail.net> writes:
>> It can be read that
>>
>> $ git cherry-pick maint next
>>
>> would pick two single commits, while
>>
>> $ git cherry-pick maint next ^master
>>
>> could implicitly be read as
>>
>> $ git cherry-pick maint next --do-walk ^master
You can read it as "master..next maint" that does force walking.
>> Clearly that's not what is intended, which is
>>
>> $ git cherry-pick --do-walk maint next ^master
I do not see the distinction betwee the above two you seem to be
trying to make. Care to explain?
>> but it is open to interpretation as to where in the command line the caret
>> range prefix's --do-walk (to countermand the --no-walk) should applied.
I do not think it can be position dependent. Philip probably has a
confused notion that "rev-list A..B C..D" is somehow a union of set
A..B and C..D?
>> If the user did want just the single commit at the tip of maint, and then
>> the range master..next, what would be their command line, and also, how
>> would the man page warn against false expectations?
Yeah, this can show us that all of the have is coming from that
exact confusion I suspected Philip has. We need to clarify in the
documentation that rev-list set operation does *NOT* have union of
multiple sets to unconfuse the readers.
next prev parent reply other threads:[~2016-09-19 16:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 10:56 clarification of `rev-list --no-walk ^<rev>`? Philip Oakley
2016-09-19 13:46 ` Michael J Gruber
2016-09-19 14:46 ` Philip Oakley
2016-09-19 16:19 ` Junio C Hamano
2016-09-19 16:12 ` Junio C Hamano [this message]
2016-09-19 19:31 ` Philip Oakley
2016-09-19 19:58 ` Junio C Hamano
2016-09-19 20:12 ` Philip Oakley
2016-09-19 21:00 ` Junio C Hamano
2016-09-19 20:44 ` Philip Oakley
2016-09-21 14:46 ` Michael J Gruber
2016-09-21 14:51 ` Michael J Gruber
2016-09-21 16:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8tunhns4.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=philipoakley@iee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).