From: Michael J Gruber <git@drmicha.warpmail.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Philip Oakley <philipoakley@iee.org>, Git List <git@vger.kernel.org>
Subject: Re: clarification of `rev-list --no-walk ^<rev>`?
Date: Wed, 21 Sep 2016 16:51:32 +0200 [thread overview]
Message-ID: <65a10cb3-ede9-a107-9d7d-ee4b5250949e@drmicha.warpmail.net> (raw)
In-Reply-To: <affca640-4ed8-268a-9f7d-e2c7ce6d66fc@drmicha.warpmail.net>
[So many typos, sorry]
Michael J Gruber venit, vidit, dixit 21.09.2016 16:46:
> Junio C Hamano venit, vidit, dixit 19.09.2016 18:12:
>> Michael J Gruber <git@drmicha.warpmail.net> writes:
>>
>>>> It can be read that
>>>>
>>>> $ git cherry-pick maint next
>>>>
>>>> would pick two single commits, while
>>>>
>>>> $ git cherry-pick maint next ^master
>>>>
>>>> could implicitly be read as
>>>>
>>>> $ git cherry-pick maint next --do-walk ^master
>>
>> You can read it as "master..next maint" that does force walking.
>>
>>>> Clearly that's not what is intended, which is
>>>>
>>>> $ git cherry-pick --do-walk maint next ^master
>>
>> I do not see the distinction betwee the above two you seem to be
>> trying to make. Care to explain?
>
> I think you answered to e-mail (in-reply-to) and to Philip's actual text
> (quotes), but just in case:
"my e-mail"
>
> [git]✓ git rev-list --no-walk ^HEAD~3 HEAD
> 47d74601f5c6bbef215a887be2ca877e34391c9f
> 574dece7b651fbae385add51d7aaea1cc414007a
> 3fbbf6e9e40b151215cce6c6e25cd4db0232d870
> [git]✓ git rev-list ^HEAD~3 --no-walk HEAD
> 47d74601f5c6bbef215a887be2ca877e34391c9f
>
> The order of revision arguments and options does play role (but where I
> put my HEAD does not, uhm), i.e. walk-options vs. negative refs.
"play a role"
"negative revs"
>
> The reason is that negative revs come with an implicit --do-walk (we
> need to walk to mark uninteresting revs), and the last
"in order to mark"
> --do-walk/--no-walk wins. That's what I meant with my comment.
>
> But there is only one walk (or none), and one setting effective for all
> revision arguments.
>
> Michael
>
next prev parent reply other threads:[~2016-09-21 14:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 10:56 clarification of `rev-list --no-walk ^<rev>`? Philip Oakley
2016-09-19 13:46 ` Michael J Gruber
2016-09-19 14:46 ` Philip Oakley
2016-09-19 16:19 ` Junio C Hamano
2016-09-19 16:12 ` Junio C Hamano
2016-09-19 19:31 ` Philip Oakley
2016-09-19 19:58 ` Junio C Hamano
2016-09-19 20:12 ` Philip Oakley
2016-09-19 21:00 ` Junio C Hamano
2016-09-19 20:44 ` Philip Oakley
2016-09-21 14:46 ` Michael J Gruber
2016-09-21 14:51 ` Michael J Gruber [this message]
2016-09-21 16:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65a10cb3-ede9-a107-9d7d-ee4b5250949e@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=philipoakley@iee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).