From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: Jeff Hostetler <git@jeffhostetler.com>,
git@vger.kernel.org, peff@peff.net,
Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH v2 0/6] Partial clone part 1: object filtering
Date: Wed, 08 Nov 2017 09:54:44 +0900 [thread overview]
Message-ID: <xmqq8tfhoai3.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20171107164118.97cc65c4030de0922b19ddd6@google.com> (Jonathan Tan's message of "Tue, 7 Nov 2017 16:41:18 -0800")
Jonathan Tan <jonathantanmy@google.com> writes:
> I can see some use for this parameter - for example, when doing a report
> for statistical purposes (percentage of objects missing, for example) or
> for a background task that downloads missing objects into a cache. Also,
> power users who know what they're doing (or normal users in an
> emergency) can use this option when they have no network connection if
> they really need to find something out from the local repo.
>
> In these cases, the promisor check (after detecting that the object is
> missing) is indeed not so useful, I think. (Or we can do the
> --exclude=missing and --exclude=promisor idea that Jeff mentioned -
> --exclude=missing now, and --exclude=promisor after we add promisor
> support.)
This sounds like a reasonable thing to have in the endgame state to
me.
> Having said that, I would be OK if we didn't have tolerance (and/or
> reporting) of missing objects right now. As far as I know, for the
> initial implementation of partial clone, only the server performs any
> filtering, and we assume that the server possesses all objects (so it
> does not need to filter out any missing objects).
True. It does not have to exist in an early part, but I do not
think we would terribly mind if it does, if only to help debugging
and development.
Thanks for thinking it through.
next prev parent reply other threads:[~2017-11-08 0:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 17:50 [PATCH v2 0/6] Partial clone part 1: object filtering Jeff Hostetler
2017-11-02 17:50 ` [PATCH v2 1/6] dir: allow exclusions from blob in addition to file Jeff Hostetler
2017-11-02 17:50 ` [PATCH v2 2/6] oidmap: add oidmap iterator methods Jeff Hostetler
2017-11-02 17:50 ` [PATCH v2 3/6] oidset: add iterator methods to oidset Jeff Hostetler
2017-11-02 17:50 ` [PATCH v2 4/6] list-objects: filter objects in traverse_commit_list Jeff Hostetler
2017-11-02 19:32 ` Jonathan Tan
2017-11-03 11:54 ` Johannes Schindelin
2017-11-03 13:37 ` Jeff Hostetler
2017-11-07 18:54 ` Jeff Hostetler
2017-11-06 17:51 ` Jeff Hostetler
2017-11-06 18:08 ` Jonathan Tan
2017-11-02 17:50 ` [PATCH v2 5/6] rev-list: add list-objects filtering support Jeff Hostetler
2017-11-02 17:50 ` [PATCH v2 6/6] pack-objects: add list-objects filtering Jeff Hostetler
2017-11-02 19:44 ` [PATCH v2 0/6] Partial clone part 1: object filtering Jonathan Tan
2017-11-03 13:43 ` Jeff Hostetler
2017-11-03 15:05 ` Junio C Hamano
2017-11-03 18:34 ` Jeff Hostetler
2017-11-08 0:41 ` Jonathan Tan
2017-11-08 0:54 ` Junio C Hamano [this message]
2017-11-08 14:39 ` Jeff Hostetler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8tfhoai3.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=jeffhost@microsoft.com \
--cc=jonathantanmy@google.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).