From: Jeff Hostetler <git@jeffhostetler.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org, gitster@pobox.com, peff@peff.net,
Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH v2 4/6] list-objects: filter objects in traverse_commit_list
Date: Fri, 3 Nov 2017 09:37:43 -0400 [thread overview]
Message-ID: <0dd48f07-6174-1a4e-c1f0-bae5b18cebd1@jeffhostetler.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1.1711031254280.6482@virtualbox>
On 11/3/2017 7:54 AM, Johannes Schindelin wrote:
> Hi Jonathan,
>
> On Thu, 2 Nov 2017, Jonathan Tan wrote:
>
>> On Thu, 2 Nov 2017 17:50:11 +0000
>> Jeff Hostetler <git@jeffhostetler.com> wrote:
>>
>>> +int parse_list_objects_filter(struct list_objects_filter_options *filter_options,
>>> + const char *arg)
>>
>> Returning void is fine, I think. It seems that all your code paths
>> either return 0 or die.
>
> Can we please start to encourage libified code, rather than discourage it?
I did that so that I could call it from the opt_parse_... version below
it that is used by the OPT_ macros.
And Johannes is right, it bothers me that there doesn't seem to be a hard
line where one should or should not call die() vs returning an error code.
Jeff
next prev parent reply other threads:[~2017-11-03 13:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 17:50 [PATCH v2 0/6] Partial clone part 1: object filtering Jeff Hostetler
2017-11-02 17:50 ` [PATCH v2 1/6] dir: allow exclusions from blob in addition to file Jeff Hostetler
2017-11-02 17:50 ` [PATCH v2 2/6] oidmap: add oidmap iterator methods Jeff Hostetler
2017-11-02 17:50 ` [PATCH v2 3/6] oidset: add iterator methods to oidset Jeff Hostetler
2017-11-02 17:50 ` [PATCH v2 4/6] list-objects: filter objects in traverse_commit_list Jeff Hostetler
2017-11-02 19:32 ` Jonathan Tan
2017-11-03 11:54 ` Johannes Schindelin
2017-11-03 13:37 ` Jeff Hostetler [this message]
2017-11-07 18:54 ` Jeff Hostetler
2017-11-06 17:51 ` Jeff Hostetler
2017-11-06 18:08 ` Jonathan Tan
2017-11-02 17:50 ` [PATCH v2 5/6] rev-list: add list-objects filtering support Jeff Hostetler
2017-11-02 17:50 ` [PATCH v2 6/6] pack-objects: add list-objects filtering Jeff Hostetler
2017-11-02 19:44 ` [PATCH v2 0/6] Partial clone part 1: object filtering Jonathan Tan
2017-11-03 13:43 ` Jeff Hostetler
2017-11-03 15:05 ` Junio C Hamano
2017-11-03 18:34 ` Jeff Hostetler
2017-11-08 0:41 ` Jonathan Tan
2017-11-08 0:54 ` Junio C Hamano
2017-11-08 14:39 ` Jeff Hostetler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dd48f07-6174-1a4e-c1f0-bae5b18cebd1@jeffhostetler.com \
--to=git@jeffhostetler.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=jonathantanmy@google.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).