git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: vmiklos@suse.cz, GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] sequencer: make sign_off_header a file local symbol
Date: Tue, 21 Nov 2017 12:10:21 +0900	[thread overview]
Message-ID: <xmqq8tf0jpia.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <xmqqy3n0jv98.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Tue, 21 Nov 2017 10:06:11 +0900")

Junio C Hamano <gitster@pobox.com> writes:

> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
>
>> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
>> ---
>>
>> Hi Miklos,
>>
>> If you need to re-roll your 'mv/cherry-pick-s' branch, could you
>> please squash this into the relevant patch (commit 5ed75e2a3f,
>> "cherry-pick: don't forget -s on failure", 14-09-2017).
>
> What automated procedure are you using to produce these comments?
>
> The commit is from 14-09-2012, not from a few months ago, and is
> part of Git 1.8.0 and upwards, which won't be rerolled.  Please add
> a check to see if the culprit is already in 'next' or something.
>
> Will queue as _your_ fix, not a potential squash into another
> commit.
>
> Thanks, as always, for your attention to detail.

Yuck.  Somebody in flight does use this symbol from elsewhere, so it
cannot be made static.  Let's drop this patch for now.

  reply	other threads:[~2017-11-21  3:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-20 20:27 [PATCH] sequencer: make sign_off_header a file local symbol Ramsay Jones
2017-11-21  1:06 ` Junio C Hamano
2017-11-21  3:10   ` Junio C Hamano [this message]
2017-11-21 10:52   ` Ramsay Jones
  -- strict thread matches above, loose matches on Subject: below --
2017-12-10  0:08 Ramsay Jones
2019-02-11 17:16 Ramsay Jones
2019-02-11 21:08 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8tf0jpia.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=ramsay@ramsayjones.plus.com \
    --cc=vmiklos@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).