From: Ramsay Jones <ramsay@ramsayjones.plus.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: vmiklos@suse.cz, GIT Mailing-list <git@vger.kernel.org>,
Phillip Wood <phillip.wood@dunelm.org.uk>
Subject: Re: [PATCH] sequencer: make sign_off_header a file local symbol
Date: Tue, 21 Nov 2017 10:52:29 +0000 [thread overview]
Message-ID: <d9d05477-5d2f-04fc-adee-10d18bc0947d@ramsayjones.plus.com> (raw)
In-Reply-To: <xmqqy3n0jv98.fsf@gitster.mtv.corp.google.com>
On 21/11/17 01:06, Junio C Hamano wrote:
> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
>
>> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
>> ---
>>
>> Hi Miklos,
>>
>> If you need to re-roll your 'mv/cherry-pick-s' branch, could you
>> please squash this into the relevant patch (commit 5ed75e2a3f,
>> "cherry-pick: don't forget -s on failure", 14-09-2017).
>
> What automated procedure are you using to produce these comments?
Err, no automated procedure, hence the idiocy ... :(
> The commit is from 14-09-2012, not from a few months ago, and is
> part of Git 1.8.0 and upwards, which won't be rerolled. Please add
> a check to see if the culprit is already in 'next' or something.
Yes, sorry, I wasn't paying attention. The actual commit which caused
the 'static-check.pl' script to bark, was d0aaa46fd3 ("commit: move empty
message checks to libgit", 10-11-2017) in the 'pu' branch. This commit
removes the last use of 'sign_off_header' outside of sequencer.c (from
builtin/commit.c).
> Will queue as _your_ fix, not a potential squash into another
> commit.
The above commit is in the 'pw/sequencer-in-process-commit' branch.
Sorry for the confusion. (Sorry Miklos).
> Thanks, as always, for your attention to detail.
Ahem. :D
ATB,
Ramsay Jones
next prev parent reply other threads:[~2017-11-21 11:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 20:27 [PATCH] sequencer: make sign_off_header a file local symbol Ramsay Jones
2017-11-21 1:06 ` Junio C Hamano
2017-11-21 3:10 ` Junio C Hamano
2017-11-21 10:52 ` Ramsay Jones [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-12-10 0:08 Ramsay Jones
2019-02-11 17:16 Ramsay Jones
2019-02-11 21:08 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9d05477-5d2f-04fc-adee-10d18bc0947d@ramsayjones.plus.com \
--to=ramsay@ramsayjones.plus.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=vmiklos@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).