git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Sebastian Staudt <koraktor@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>, Jeff King <peff@peff.net>,
	Duy Nguyen <pclouds@gmail.com>
Subject: Re: [PATCH v4 2/2] t6120: test for describe with a bare repository
Date: Fri, 01 Feb 2019 10:53:27 -0800	[thread overview]
Message-ID: <xmqq7eejz6fs.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190201135512.68220-2-koraktor@gmail.com> (Sebastian Staudt's message of "Fri, 1 Feb 2019 14:55:12 +0100")

Sebastian Staudt <koraktor@gmail.com> writes:

> This ensures that nothing breaks the basic functionality of describe for
> bare repositories. Please note that --broken and --dirty need a working
> tree.
>
> Signed-off-by: Sebastian Staudt <koraktor@gmail.com>
> ---
>  t/t6120-describe.sh | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/t/t6120-describe.sh b/t/t6120-describe.sh
> index 7cfed77c52..ea2c3dbe1c 100755
> --- a/t/t6120-describe.sh
> +++ b/t/t6120-describe.sh
> @@ -418,4 +418,9 @@ test_expect_success 'describe complains about missing object' '
>  	test_must_fail git describe $ZERO_OID
>  '
>  
> +test_expect_success 'describe works from outside repo using --git-dir' ' 
> +  git clone --bare "$TRASH_DIRECTORY" "$TRASH_DIRECTORY/bare" &&
> +  git --git-dir "$TRASH_DIRECTORY/bare" describe
> +'

OK, it demonstrates that the command exits with status 0.  Do we
want to validate its output, too?

  reply	other threads:[~2019-02-01 18:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-01 13:55 [PATCH v4 1/2] describe: setup working tree for --dirty Sebastian Staudt
2019-02-01 13:55 ` [PATCH v4 2/2] t6120: test for describe with a bare repository Sebastian Staudt
2019-02-01 18:53   ` Junio C Hamano [this message]
2019-02-02 10:00     ` Sebastian Staudt
2019-02-01 20:12 ` [PATCH v4 1/2] describe: setup working tree for --dirty Eric Sunshine
2019-02-02 10:04   ` Sebastian Staudt
2019-02-03  3:35     ` Eric Sunshine
2019-02-01 20:52 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7eejz6fs.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=koraktor@gmail.com \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).