From: Eric Sunshine <sunshine@sunshineco.com>
To: Sebastian Staudt <koraktor@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
Duy Nguyen <pclouds@gmail.com>
Subject: Re: [PATCH v4 1/2] describe: setup working tree for --dirty
Date: Sat, 2 Feb 2019 22:35:03 -0500 [thread overview]
Message-ID: <CAPig+cRg55g_x7XvfHuP4J17ODnmWp+o7x=Wqpq6v2TCWcgcuw@mail.gmail.com> (raw)
In-Reply-To: <CA+xP2Sa2zLeLg-6pFn9UEufurd=EOOf8UFx3Qh7o0dwzJgN-ag@mail.gmail.com>
On Sat, Feb 2, 2019 at 5:05 AM Sebastian Staudt <koraktor@gmail.com> wrote:
> Am Fr., 1. Feb. 2019 um 21:12 Uhr schrieb Eric Sunshine
> <sunshine@sunshineco.com>:
> > On Fri, Feb 1, 2019 at 8:55 AM Sebastian Staudt <koraktor@gmail.com> wrote:
> > > diff --git a/t/t6120-describe.sh b/t/t6120-describe.sh
> > > @@ -145,14 +145,38 @@ check_describe A-* HEAD
> > > +test_expect_success 'describe --dirty with --work-tree' '
> > > + [...]
> > > +'
> > > +test_expect_success 'describe --dirty with --work-tree' '
> > > + [...]
> > > +'
> >
> > Can you give these two new tests different titles to make it easier to
> > narrow down a problem to one or the other if one of them does fail?
> > Perhaps the second test could be titled:
> >
> > test_expect_success 'describe --dirty with dirty --work-tree' '
> >
> > or something.
>
> Thanks, didn‘t notice this.
> I‘d use a suffix (dirty) for my test titles. But this won‘t work for tests
> using check_describe(). Any objections?
I have no objections to using suffix "(dirty)".
It's true that there are a few duplicate test titles due to
check_describe() invocations, however, this patch isn't introducing
any new callers, so it's not strictly a concern of this series. If you
did want to address that issue, one possibility would be to add a
'title' argument to check_describe() and adjust callers to use a
unique title, however, such a change would not be part of this
particular patch, and I'm not convinced that it's even worth the
effort and churn at this point.
next prev parent reply other threads:[~2019-02-03 3:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 13:55 [PATCH v4 1/2] describe: setup working tree for --dirty Sebastian Staudt
2019-02-01 13:55 ` [PATCH v4 2/2] t6120: test for describe with a bare repository Sebastian Staudt
2019-02-01 18:53 ` Junio C Hamano
2019-02-02 10:00 ` Sebastian Staudt
2019-02-01 20:12 ` [PATCH v4 1/2] describe: setup working tree for --dirty Eric Sunshine
2019-02-02 10:04 ` Sebastian Staudt
2019-02-03 3:35 ` Eric Sunshine [this message]
2019-02-01 20:52 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cRg55g_x7XvfHuP4J17ODnmWp+o7x=Wqpq6v2TCWcgcuw@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=koraktor@gmail.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).