git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Teng Long <dyroneteng@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3 2/3] update-index: add --show-index-version
Date: Tue, 14 Nov 2023 11:55:28 +0900	[thread overview]
Message-ID: <xmqq7cml11sv.fsf@gitster.g> (raw)
In-Reply-To: <20231114021839.8275-1-tenglong.tl@alibaba-inc.com> (Teng Long's message of "Tue, 14 Nov 2023 10:18:38 +0800")

Teng Long <dyroneteng@gmail.com> writes:

> Junio C Hamano <gitster@pobox.com> writes:
>
>> @@ -1181,15 +1183,20 @@ int cmd_update_index(int argc, const char **argv, const char *prefix)
>>  
>>  	getline_fn = nul_term_line ? strbuf_getline_nul : strbuf_getline_lf;
>>  	if (preferred_index_format) {
>> -		if (preferred_index_format < INDEX_FORMAT_LB ||
>> -		    INDEX_FORMAT_UB < preferred_index_format)
>> +		if (preferred_index_format < 0) {
>> +			printf(_("%d\n"), the_index.version);
>
> Maybe the "%d\n" shouldn't be translated? :)

Excellent.


  reply	other threads:[~2023-11-14  2:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-18 23:37 [PATCH v2 0/3] "update-index --show-index-version" Junio C Hamano
2023-08-18 23:37 ` [PATCH v2 1/3] update-index doc: v4 is OK with JGit and libgit2 Junio C Hamano
2023-09-12  4:57   ` Linus Arver
2023-09-12 17:14     ` Junio C Hamano
2023-08-18 23:37 ` [PATCH v2 2/3] update-index: add --show-index-version Junio C Hamano
2023-09-12  5:54   ` Linus Arver
2023-09-12 19:01     ` Junio C Hamano
2023-08-18 23:37 ` [PATCH v2 3/3] test-tool: retire "index-version" Junio C Hamano
2023-09-12  6:10   ` Linus Arver
2023-09-12 19:32 ` [PATCH v3 0/3] "update-index --show-index-version" Junio C Hamano
2023-09-12 19:32   ` [PATCH v3 1/3] update-index doc: v4 is OK with JGit and libgit2 Junio C Hamano
2023-09-12 19:32   ` [PATCH v3 2/3] update-index: add --show-index-version Junio C Hamano
2023-11-14  2:18     ` Teng Long
2023-11-14  2:55       ` Junio C Hamano [this message]
2023-09-12 19:32   ` [PATCH v3 3/3] test-tool: retire "index-version" Junio C Hamano
2023-09-14  6:19   ` [PATCH v3 0/3] "update-index --show-index-version" Linus Arver
2023-09-14 18:15     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7cml11sv.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=dyroneteng@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).