From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS54825 139.178.88.0/22 X-Spam-Status: No, score=-2.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org [139.178.88.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 7C3781F406 for ; Tue, 14 Nov 2023 02:55:43 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.a=rsa-sha256 header.s=sasl header.b=hxcgISRF; dkim-atps=neutral Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4C22F2810AF for ; Tue, 14 Nov 2023 02:55:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4872D79DE; Tue, 14 Nov 2023 02:55:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b="hxcgISRF" Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 792047E for ; Tue, 14 Nov 2023 02:55:35 +0000 (UTC) Received: from pb-smtp20.pobox.com (pb-smtp20.pobox.com [173.228.157.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CCC312D for ; Mon, 13 Nov 2023 18:55:34 -0800 (PST) Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id BF4322C417; Mon, 13 Nov 2023 21:55:33 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=WYdRlYWjKCe80HNRpX79oZP+Cz4o/bvSPJhDw6 Poa50=; b=hxcgISRFrn2eJZhOPSsX1RjL4CKuBmZK7FAt4Xb2MyIn0bwIy6A9l+ Q81tlS/Q/0CAWjauZXq3Crz2RX6oz03GaTLsLCV5z0bgsiS0Zi0tbO/FCxRlkktF G3x4MsU26i1K8TODROCCIpuahXbctPGz95NJt2XufUAQu2q7Vw/WE= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id B82492C416; Mon, 13 Nov 2023 21:55:33 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.125.153.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 5E0382C407; Mon, 13 Nov 2023 21:55:30 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Teng Long Cc: git@vger.kernel.org Subject: Re: [PATCH v3 2/3] update-index: add --show-index-version In-Reply-To: <20231114021839.8275-1-tenglong.tl@alibaba-inc.com> (Teng Long's message of "Tue, 14 Nov 2023 10:18:38 +0800") References: <20230912193235.776292-3-gitster@pobox.com> <20231114021839.8275-1-tenglong.tl@alibaba-inc.com> Date: Tue, 14 Nov 2023 11:55:28 +0900 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 4593F282-8299-11EE-A540-F515D2CDFF5E-77302942!pb-smtp20.pobox.com Teng Long writes: > Junio C Hamano writes: > >> @@ -1181,15 +1183,20 @@ int cmd_update_index(int argc, const char **argv, const char *prefix) >> >> getline_fn = nul_term_line ? strbuf_getline_nul : strbuf_getline_lf; >> if (preferred_index_format) { >> - if (preferred_index_format < INDEX_FORMAT_LB || >> - INDEX_FORMAT_UB < preferred_index_format) >> + if (preferred_index_format < 0) { >> + printf(_("%d\n"), the_index.version); > > Maybe the "%d\n" shouldn't be translated? :) Excellent.