git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH] t5404: relax overzealous test
Date: Mon, 09 Apr 2018 11:21:41 +0900	[thread overview]
Message-ID: <xmqq60516rwq.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180406195331.GC11450@sigill.intra.peff.net> (Jeff King's message of "Fri, 6 Apr 2018 15:53:31 -0400")

Jeff King <peff@peff.net> writes:

> On Fri, Apr 06, 2018 at 09:31:22PM +0200, Johannes Schindelin wrote:
>
>> In 0b294c0abf0 (make deleting a missing ref more quiet, 2008-07-08), we
>> added a test to verify that deleting an already-deleted ref does not
>> show an error.
>
> Amazing that it took this long to come up.
> ...
>> This patch chooses instead to look for the prefix "error:" at the
>> beginning of the line, so that there can be no ambiguity that any catch
>> was indeed a message generated by Git's `error_builtin()` function.
>
> Yep, this seems obviously correct.

Hits in

    $ git grep 'grep ["'\'']*error' t

shows that many checks for errors that are not anchored, but I do
not think any of them are looking for the string in a pathname other
than this instance, so it would be OK.

Thanks, both.  Will apply.



  parent reply	other threads:[~2018-04-09  2:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-06 19:31 [PATCH] t5404: relax overzealous test Johannes Schindelin
2018-04-06 19:53 ` Jeff King
2018-04-06 20:13   ` Johannes Schindelin
2018-04-06 20:16     ` Jeff King
2018-04-06 20:35   ` Ævar Arnfjörð Bjarmason
2018-04-09  2:21   ` Junio C Hamano [this message]
2018-04-09  2:21     ` Junio C Hamano
2018-04-09 13:52     ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq60516rwq.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).