mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <>
To: "נעם סולוביצ'יק" <>
Subject: Re: Why is AuthorDate displayed on git-blame?
Date: Tue, 04 Aug 2020 17:40:26 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (=?utf-8?B?Iteg16LXnSDXodeV15zXldeR15nXpifXmdenIidz?= message of "Wed, 5 Aug 2020 03:18:43 +0300")

נעם סולוביצ'יק  <> writes:

> A feature branch having commits authored last week, but merged to the
> main branch just today. And to the sake of discussion, let's say that
> the branch has a bug.
> When someone encounters the bug on the main branch, he would probably
> want to know when it was introduced - the date when the bug started
> to affect him. However, git-blame only shows him when the bug was
> originally authored, in our case - *last-week*, which is confusing
> since the main branch was working just fine back then.
> So I wonder why was AuthorDate the date chosen to be displayed under
> git-blame?

Quite honestly, the left-hand side of "git blame" output is not all
that useful, as the usual workflow is to use "blame" to only to
identify a commit (or a set of commits) and from there, any detailed
information of problematic commits will be inspected with "git show"
or equivalent, so in that sense, "git blame -s" could be the most
useful output format.

It should be trivial to add an option to show the commit date
instead, so in that sense, the answer to the immediate question "why
author date?" is "just because we chose to show it; you are welcome
to send in a patch to add an option to show committer date".  

However, your question has another ingredient that is much more
interesting.  If you are interested only at the level of changes to
the primary integration branch, showing either author or committer
date of the ultimately responsible individual commit that was
brought in by a merge of a topic branch to the integration branch is
not useful at all for your purpose.  You need to find out which
merge brought the change to the integraiton branch and you do not
care which individual commit on the side branch that was merged.

IOW, what you would want is a "git blame --first-parent".

  reply	other threads:[~2020-08-05  0:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-05  0:18 Why is AuthorDate displayed on git-blame? נעם סולוביצ'יק
2020-08-05  0:40 ` Junio C Hamano [this message]
2020-08-06  6:57   ` Raymond E. Pasco
2020-08-06 15:19     ` Noam Soloveichik
2020-08-06 18:13       ` Raymond E. Pasco
2020-08-06 18:17     ` Junio C Hamano
2020-08-06 18:52       ` [PATCH] blame-options.txt: document --first-parent option Raymond E. Pasco
2020-08-08  0:35       ` Why is AuthorDate displayed on git-blame? Jeff King
2020-08-05  1:59 ` brian m. carlson
2020-08-05 16:08   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).