mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "brian m. carlson" <>
To: "נעם סולוביצ'יק" <>
Subject: Re: Why is AuthorDate displayed on git-blame?
Date: Wed, 5 Aug 2020 01:59:39 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

[-- Attachment #1: Type: text/plain, Size: 1943 bytes --]

On 2020-08-05 at 00:18:43, נעם סולוביצ'יק wrote:
> Hey everybody, I wonder about the decision behind git-blame and
> git-annotate date that is being shown.
> If I understand correctly, the AuthorDate is displayed, and I'd like
> to challenge that decision. Consider the following case:
> A feature branch having commits authored last week, but merged to the
> main branch just today. And to the sake of discussion, let's say that
> the branch has a bug.
> When someone encounters the bug on the main branch, he would probably
> want to know when it was introduced - the date when the bug started
> to affect him. However, git-blame only shows him when the bug was
> originally authored, in our case - *last-week*, which is confusing
> since the main branch was working just fine back then.
> So I wonder why was AuthorDate the date chosen to be displayed under
> git-blame?

I can't speak for the original author of this, and I think Junio's
answer explains this well, but I'd like to add an additional thought on
why the current behavior is useful.

For me, I am primarily interested in using blame to find information
about the party most knowledgable about the subsystem or area, or to
find a commit that introduced a change (possibly so I can read its
commit message or pull request).  I'm less likely to use blame to, well,
blame people.  Consequently, it's often helpful for me to know about
when the code was written, since that tells me more about the author and
their situation than the committer information does.

For a project like Git, the committer information would not be very
interesting to me, since Junio, while very competent, is not the expert
for every line in the codebase.  Since we're displaying the author name,
we might as well display the author timestamp as well.

I'm in favor of an option for this, though.
brian m. carlson: Houston, Texas, US

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

  parent reply	other threads:[~2020-08-05  2:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-05  0:18 Why is AuthorDate displayed on git-blame? נעם סולוביצ'יק
2020-08-05  0:40 ` Junio C Hamano
2020-08-06  6:57   ` Raymond E. Pasco
2020-08-06 15:19     ` Noam Soloveichik
2020-08-06 18:13       ` Raymond E. Pasco
2020-08-06 18:17     ` Junio C Hamano
2020-08-06 18:52       ` [PATCH] blame-options.txt: document --first-parent option Raymond E. Pasco
2020-08-08  0:35       ` Why is AuthorDate displayed on git-blame? Jeff King
2020-08-05  1:59 ` brian m. carlson [this message]
2020-08-05 16:08   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).