From: Junio C Hamano <gitster@pobox.com>
To: Max Kirillov <max@max630.net>
Cc: Paul Mackerras <paulus@ozlabs.org>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
git@vger.kernel.org
Subject: Re: [PATCH] gitk: expand $config_file_tmp before reporting to user
Date: Thu, 28 Sep 2017 13:37:36 +0900 [thread overview]
Message-ID: <xmqq4lrn30bz.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170928041417.28947-1-max@max630.net> (Max Kirillov's message of "Thu, 28 Sep 2017 07:14:17 +0300")
Max Kirillov <max@max630.net> writes:
> Tilda-based path may confise some users. First, tilda is not known
> for Window users, second, it may point to unexpected location
> depending on various environment setup.
>
> Expand the path to "nativename", so that ~/.config/git/gitk-tmp
> would be "C:\Users\user\.config\git\gitk-tmp", for example.
> It should be less cryptic
It might be less cryptic, but for those of us whose $HOME is a
looooooong path, ~/.config/git/gitk-tmp is much easier to understand
than the same path with ~/ expanded, which would push the part of
the filename that most matters far to the right hand side of the
dialog.
I somehow find this change just robbing Peter to pay Paul.
> } else {
> - error_popup "There appears to be a stale $config_file_tmp\
> + error_popup "There appears to be a stale \
> + \"[file nativename $config_file_tmp]\" \
next prev parent reply other threads:[~2017-09-28 4:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 4:14 [PATCH] gitk: expand $config_file_tmp before reporting to user Max Kirillov
2017-09-28 4:37 ` Junio C Hamano [this message]
2017-09-28 4:47 ` Junio C Hamano
2017-09-28 12:31 ` Johannes Schindelin
2017-09-28 22:03 ` Junio C Hamano
2017-09-29 4:34 ` Max Kirillov
2017-09-29 20:24 ` Uxío Prego
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4lrn30bz.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=max@max630.net \
--cc=paulus@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).