From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Max Kirillov <max@max630.net>, Paul Mackerras <paulus@ozlabs.org>,
git@vger.kernel.org
Subject: Re: [PATCH] gitk: expand $config_file_tmp before reporting to user
Date: Thu, 28 Sep 2017 14:31:17 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1.1709281428170.40514@virtualbox> (raw)
In-Reply-To: <xmqqzi9f1lb2.fsf@gitster.mtv.corp.google.com>
Hi Junio,
On Thu, 28 Sep 2017, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
> > Max Kirillov <max@max630.net> writes:
> >
> >> Tilda-based path may confise some users. First, tilda is not known
> >> for Window users, second, it may point to unexpected location
> >> depending on various environment setup.
> >>
> >> Expand the path to "nativename", so that ~/.config/git/gitk-tmp
> >> would be "C:\Users\user\.config\git\gitk-tmp", for example.
> >> It should be less cryptic
Thanks, Max, for your contribution!
> > It might be less cryptic, but for those of us whose $HOME is a
> > looooooong path, ~/.config/git/gitk-tmp is much easier to understand
> > than the same path with ~/ expanded, which would push the part of
> > the filename that most matters far to the right hand side of the
> > dialog.
Heh, do you want to know how that must sound to a Windows user? I'm not
saying that I am a hard-core Windows user, but I do know a few, and I
already hear their comments in their own voice in my head...
> > I somehow find this change just robbing Peter to pay Paul.
>
> Having said that, because a set-up might have HOME or XDG_CONFIG or
> other things misconfigured to point at a place where the end user
> may not be expecting, I tend to think that catering to Paul by
> showing the information closer to the bare metal is much more worthy
> thing to do than keeping Peter happy. Since this is an error path,
> accuracy trumps convenience.
>
> So no objection from me (unless somebody else comes up with an
> alternative that would make both camps happy, that is).
To Unix/Linux users, the tilde (or Tilda, I really like that nickname, it
makes it much more human and tolerable) is probably *very* familiar.
As familiar, as it is unfamiliar to Windows users.
So I would actually suggest to make this a conditional on the platform: on
Windows, use the native name, everywhere else, not.
Sound good?
Johannes
next prev parent reply other threads:[~2017-09-28 12:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 4:14 [PATCH] gitk: expand $config_file_tmp before reporting to user Max Kirillov
2017-09-28 4:37 ` Junio C Hamano
2017-09-28 4:47 ` Junio C Hamano
2017-09-28 12:31 ` Johannes Schindelin [this message]
2017-09-28 22:03 ` Junio C Hamano
2017-09-29 4:34 ` Max Kirillov
2017-09-29 20:24 ` Uxío Prego
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1.1709281428170.40514@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=max@max630.net \
--cc=paulus@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).