From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: dyroneteng@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH] Optimize the description of the configuration in packfile-uris doc
Date: Fri, 07 May 2021 06:39:31 +0900 [thread overview]
Message-ID: <xmqq4kffy224.fsf@gitster.g> (raw)
In-Reply-To: <20210506164728.336409-1-jonathantanmy@google.com> (Jonathan Tan's message of "Thu, 6 May 2021 09:47:28 -0700")
Jonathan Tan <jonathantanmy@google.com> writes:
>> There is a description problem in the document about packfile-uris. This
>> patch describes the configuration format of `uploadpack.blobPackfileUri`
>> more accurately.
>
> Thanks for noticing this. The diff itself is correct, of course.
>
> As for the commit message, limit the title to 50 characters or fewer if
> possible. Maybe something like "packfile-uri.txt: fix blobPackfileUri
> description" or something like that.
>
> Also in the commit message, maybe mention that the correct format can be
> seen in t5702.
Thanks for giving a review with clear suggestion for improvements,
Jonathan. And thanks for contributing, Teng.
Will look forward to seeing an updated patch.
next prev parent reply other threads:[~2021-05-06 21:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 7:33 [PATCH] Optimize the description of the configuration in packfile-uris doc Teng Long
2021-05-06 16:47 ` Jonathan Tan
2021-05-06 21:39 ` Junio C Hamano [this message]
2021-05-11 6:45 ` [PATCH v2] packfile-uri.txt: fix blobPackfileUri description Teng Long
2021-05-11 20:50 ` Junio C Hamano
2021-05-12 14:10 ` Long Teng
2021-05-12 23:32 ` Junio C Hamano
2021-05-13 7:15 ` Teng Long
2021-05-13 21:33 ` Junio C Hamano
2021-05-18 0:44 ` Junio C Hamano
2021-05-24 15:43 ` Jonathan Tan
2021-05-25 0:34 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2021-05-13 2:45 [PATCH] Optimize the description of the configuration in packfile-uris doc Teng Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4kffy224.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=dyroneteng@gmail.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).