From: Junio C Hamano <gitster@pobox.com>
To: Long Teng <dyroneteng@gmail.com>
Cc: git@vger.kernel.org, Jonathan Tan <jonathantanmy@google.com>
Subject: Re: [PATCH v2] packfile-uri.txt: fix blobPackfileUri description
Date: Thu, 13 May 2021 08:32:18 +0900 [thread overview]
Message-ID: <xmqq7dk3edfh.fsf@gitster.g> (raw)
In-Reply-To: <CADMgQSQfvacwfnhz=taR5904AJp=CWgiq50+5F0A=hN4jGo9pg@mail.gmail.com> (Long Teng's message of "Wed, 12 May 2021 22:10:29 +0800")
Long Teng <dyroneteng@gmail.com> writes:
>>It seems that the above needs a bit more polishing?
>>
>>I am not sure if moving the sign-off higher and inserting a
>>three-dash line before "Jonathan Tan writes" would be sufficient,
>>but with everything under that quoted material does not seem to
>>belong to a proposed commit log message proper.
>
> Sorry, I misunderstood.
>
> I looked at some patches in the community. If I reply to the
> reviewer’s suggestion separately and then submit a new patch, is it
> the recommended way? (Distinguish between the ‘reply‘ and the
> 'patch').
Yes. Some people seem to omit the final response to reviewer
suggestions on the previous round and just send a revised patch, but
it is much nicer to cleanly conclude the review cycle for the
previous round with a separate response (it could just be "yes,
you're right---I'll incorporate your suggestions in the next round,
thanks") before starting a new cycle.
And the "patch" side should be written to be understandable even by
those who do not have access to the review history of the previous
round(s)---imagine how it appears in "git log" output to those who
did not read the discussion on this mailing list, and write for
them.
Thanks.
next prev parent reply other threads:[~2021-05-12 23:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 7:33 [PATCH] Optimize the description of the configuration in packfile-uris doc Teng Long
2021-05-06 16:47 ` Jonathan Tan
2021-05-06 21:39 ` Junio C Hamano
2021-05-11 6:45 ` [PATCH v2] packfile-uri.txt: fix blobPackfileUri description Teng Long
2021-05-11 20:50 ` Junio C Hamano
2021-05-12 14:10 ` Long Teng
2021-05-12 23:32 ` Junio C Hamano [this message]
2021-05-13 7:15 ` Teng Long
2021-05-13 21:33 ` Junio C Hamano
2021-05-18 0:44 ` Junio C Hamano
2021-05-24 15:43 ` Jonathan Tan
2021-05-25 0:34 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2021-05-13 6:44 [PATCH v2] " Teng Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7dk3edfh.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=dyroneteng@gmail.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).