From: Junio C Hamano <gitster@pobox.com>
To: "Zoë Blade" <zoe@bytenoise.co.uk>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] userdiff: add support for Fountain documents
Date: Fri, 17 Jul 2015 15:43:15 -0700 [thread overview]
Message-ID: <xmqq380m1k3g.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <xmqq1tg63dzv.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Fri, 17 Jul 2015 10:12:04 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Zoë Blade <zoe@bytenoise.co.uk> writes:
>
>> More information about the Fountain format can be found on its
>> official website, at http://fountain.io .
So I visited there.
>> +PATTERNS("fountain", "^((INT|EST|EXT)?\\.[A-Z0-9' -]+)$",
>> + "[^ \t-]+"),
After skimming http://fountain.io/syntax I am getting the impression
that this might be a bit too limiting.
* Although uppercase is recommended for Scene Headings to increase
readability, it is not required.
* A line beginning with any of the following, followed by either a
dot or a space, is considered a Scene Heading (unless the line is
preceded by an exclamation point !). Case insensitive.
INT
EXT
EST
INT./EXT
INT/EXT
I/E
* You can "force" a Scene Heading by starting the line with a
single period.
* Scene Headings can optionally be appended with Scene
Numbers. Scene numbers are any alphanumerics (plus dashes and
periods), wrapped in #.
So, it appears wrong to insist on capital letters in the patterns.
The pattern in the patch does not even accept punctuations on the
line other than apostrophe. I won't judge if it is OK to limit to
US-ASCII ;-)
IPATTERNS("fountain",
"^([.][^.]|(INT|EXT|EST|INT./EXT|INT/EXT|I/E)[. ]",
"[^ \t-]+"),
or something like this, perhaps?
next prev parent reply other threads:[~2015-07-17 22:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 14:21 [PATCH] userdiff: add support for Fountain documents Zoë Blade
2015-07-17 17:12 ` Junio C Hamano
2015-07-17 22:43 ` Junio C Hamano [this message]
2015-07-19 12:30 ` Zoë Blade
-- strict thread matches above, loose matches on Subject: below --
2015-07-21 13:22 Zoë Blade
2015-07-21 19:33 ` Junio C Hamano
2015-07-22 16:31 ` Zoë Blade
2015-07-29 11:19 ` Zoë Blade
2015-07-19 12:31 Zoë Blade
2015-07-20 21:17 ` Junio C Hamano
2015-07-21 13:23 ` Zoë Blade
2015-07-17 11:59 Zoë Blade
2015-07-17 13:03 ` Johannes Schindelin
2015-07-17 14:03 ` Zoë Blade
2015-07-17 16:20 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq380m1k3g.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=zoe@bytenoise.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).